Conversation
come-nc
force-pushed
the
come/allow-list-hooks
branch
4 times, most recently
from
September 17, 2026 12:14
50f1f1d to
ec35b78
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
come-nc
force-pushed
the
come/allow-list-hooks
branch
2 times, most recently
from
September 17, 2026 14:35
70a8a56 to
ceb095f
Compare
come-nc
marked this pull request as ready for review
September 17, 2026 15:55
come-nc
requested review from
Altahrim,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
September 17, 2026 15:55
come-nc
added
3. to review
CarlSchwan
approved these changes
Sep 17, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Allow to use ::class as class names. Only works if the class actually exists, which in many case, isn't the case anymore. Signed-off-by: Carl Schwan <carlschwan@kde.org>
And replace the few remaining by converting the event to hooks instead of the other way around. Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Allow to get rid of more legacy code and make sure UserSessionTest is also in psalm Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Registering listeners was messing with other tests, use a mocked event dispatcher instead. Also fixed a few constructor calls. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
The listener can simply be added with the other ones. For the tests we have to call the method manually as the listener does not target the same instance. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
We have to call the event handling manually when the event dispatcher is mocked. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…pleteLogin Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
come/allow-list-hooks
branch
from
September 17, 2026 16:07
ee3b3be to
e69d06d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same as #59489 but rebased on master.
I pushed as a new PR because there was a lot of conflicts, wanted to make sure I did not miss anything.
Checklist
3. to review, feature component)stable32)AI (if applicable)