[stable35] fix(files_sharing): bump @nextcloud/sharing to 1.0.0-beta.4 - #64155
Open
skjnldsv wants to merge 1 commit into
Open
[stable35] fix(files_sharing): bump @nextcloud/sharing to 1.0.0-beta.4#64155skjnldsv wants to merge 1 commit into
skjnldsv wants to merge 1 commit into
Conversation
Brings three fixes to the dialog: the sharee is called "recipient" throughout, the scrollbar sits at the dialog edge instead of floating over the form, and the recipient menu closes when it opens the permissions modal. The sidebar's own "Remove participant" follows the same wording. Signed-off-by: Barthelemy Briand <barthelemy.briand@nextcloud.com> Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
requested review from
kristian-zendato,
sorbaugh and
susnux
and removed request for
a team
September 9, 2026 18:36
susnux
approved these changes
Sep 10, 2026
provokateurin
approved these changes
Sep 10, 2026
AndyScherzinger
approved these changes
Sep 10, 2026
Member
Author
|
/compile rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up
@nextcloud/sharing1.0.0-beta.4, which fixes three things reported against the dialog: the sharee is called "recipient" throughout instead of a mix of people, participants and recipients; the scrollbar sits at the dialog edge rather than floating over the form; and the recipient menu closes when it opens the permissions modal instead of overlapping it.The sidebar has its own "Remove participant" action, so it follows the same wording, along with the tests that assert those labels.
The translated strings in
apps/files_sharing/l10n/still carry the old wording; those come from Transifex and update on the next sync.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)