[stable30] fix(sharing): properly frame block list - #63930
Merged
Merged
Conversation
backportbot
Bot
requested review from
provokateurin,
salmart-dev,
skjnldsv and
susnux
September 2, 2026 07:23
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> Assisted-by: ClaudeCode:claude-opus-5
susnux
force-pushed
the
backport/63828/stable30
branch
from
September 15, 2026 18:05
7b3e8cd to
26167b6
Compare
susnux
marked this pull request as ready for review
September 15, 2026 18:05
susnux
requested review from
SebastianKrupinski and
hamza221
as code owners
September 15, 2026 18:05
susnux
approved these changes
Sep 15, 2026
skjnldsv
approved these changes
Sep 15, 2026
The scenarios added for the block and allow list set `shareapi_exclude_groups` and `shareapi_exclude_groups_list`, but neither context removed them again. As `resetAppConfigs()` runs before every scenario, the values leaked into all following scenarios of the sharees and contacts-menu features and made them fail. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
backport/63828/stable30
branch
from
September 15, 2026 22:53
46384cd to
2184edc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #63828
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.