Skip to content

Move invite-accepted capability and implementation to contacts app.#57853

Open
redblom wants to merge 1 commit into
nextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app
Open

Move invite-accepted capability and implementation to contacts app.#57853
redblom wants to merge 1 commit into
nextcloud:masterfrom
redblom:move-ocm-invite-accepted-route-impl-to-contacts-app

Conversation

@redblom

@redblom redblom commented Jan 27, 2026 •
edited by miaulalala
Loading

Copy link
Copy Markdown
  • Resolves: #

Summary

Code moved to contacts app, see nextcloud/contacts#4417

TODO

  • deal with inviteAcceptedDialog code

Checklist

@redblom redblom requested a review from a team as a code owner January 27, 2026 15:43
@redblom redblom requested review from leftybournes, nfebe, salmart-dev and sorbaugh and removed request for a team January 27, 2026 15:43
@redblom redblom marked this pull request as draft January 27, 2026 15:43
@ChristophWurst

ChristophWurst commented Jan 28, 2026

Copy link
Copy Markdown
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 7cb53f3 to 2d2e4a1 Compare January 28, 2026 16:58
@ArtificialOwl

ArtificialOwl commented Jan 28, 2026

Copy link
Copy Markdown
Member

@redblom why is this moved out of server and could it break OCM when the contacts app is not installed? the app is not shipped. it is optional.

This is done on my request:

  • it is moved out of server because the implementation of the feature creates its own db table and does not provide an API to manage it,
  • it will not break OCM, it will only not enable the 'invite-accepted' capability if contacts is not installed. the capability is useless without the contacts app,
  • contacts will register the capability and fully manage the db table

@ArtificialOwl

ArtificialOwl commented Jan 28, 2026

Copy link
Copy Markdown
Member

let's ping @mickenordin on this one !

@mickenordin mickenordin force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2d2e4a1 to aea3c70 Compare January 28, 2026 18:22
@mickenordin

mickenordin commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

let's ping @mickenordin on this one !

I haven't reviewed the change, but in principal I see no problem with it.

@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from aea3c70 to 254681c Compare January 30, 2026 09:26
@redblom

redblom commented Jan 30, 2026

Copy link
Copy Markdown
Author

Rebased, squashed, removed draft label.

@redblom redblom marked this pull request as ready for review January 30, 2026 10:12
@redblom redblom requested review from a team and nickvergessen as code owners January 30, 2026 10:12
nickvergessen
nickvergessen requested changes Jan 30, 2026
View reviewed changes
Comment thread apps/cloud_federation_api/lib/Migration/Version1016Date202502262004.php
Comment thread lib/public/OCM/Events/LocalOCMDiscoveryEvent.php Outdated
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 3948b49 to 57769de Compare February 4, 2026 09:30
@redblom redblom requested a review from nickvergessen February 4, 2026 09:33
@github-actions

github-actions Bot commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@miaulalala

This comment was marked as resolved.

Sign in to view
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 7f0ecf2 to ddfe68d Compare February 17, 2026 10:36
@redblom

This comment was marked as resolved.

Sign in to view
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 3 times, most recently from ded9475 to b858195 Compare May 4, 2026 09:51
@miaulalala miaulalala force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from b858195 to 97e2819 Compare May 4, 2026 11:28
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2a153f1 to cc94400 Compare May 7, 2026 16:37
@redblom

redblom commented May 8, 2026

Copy link
Copy Markdown
Author

@artonge, @nickvergessen - I believe it's all there now. Can you check/review?

@MahdiBaghbani MahdiBaghbani mentioned this pull request May 12, 2026
Merged
@sorbaugh

sorbaugh commented May 13, 2026

Copy link
Copy Markdown
Contributor

/backport to stable33

@redblom redblom mentioned this pull request May 13, 2026
Open
mickenordin added a commit to SUNET/nextcloud-ocm_request_share that referenced this pull request May 16, 2026
@mickenordin
Advertise request-share capability via LocalOCMDiscoveryEvent
9203793 
Listens to LocalOCMDiscoveryEvent (the +11-line API exposed by
nextcloud/server#57853) and appends 'request-share' to the local OCM
provider's capabilities array, so federation peers learn this server
accepts POST /ocm/request-share.
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 264a1de to 9c2436a Compare May 18, 2026 12:29
@miaulalala

This comment was marked as outdated.

Sign in to view
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 3f39759 to 2dd0a1d Compare May 20, 2026 09:38
@redblom

This comment was marked as outdated.

Sign in to view
@miaulalala

This comment was marked as outdated.

Sign in to view
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 2dd0a1d to 9dfb752 Compare June 3, 2026 15:57
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jun 9, 2026
@redblom redblom closed this Jun 19, 2026
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from 9dfb752 to 43701a5 Compare June 19, 2026 15:57
@redblom

redblom commented Jun 19, 2026

Copy link
Copy Markdown
Author

Rebased from master.

@redblom redblom reopened this Jun 19, 2026
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch 2 times, most recently from 4c0881f to f532694 Compare June 22, 2026 13:54
@redblom
fix(ocm): Move invite-accepted capability and implementation to conta…
b94189b 
…cts app.

Signed-off-by: Antoon P. <antoon.prins@surf.nl>
@redblom redblom force-pushed the move-ocm-invite-accepted-route-impl-to-contacts-app branch from f532694 to b94189b Compare June 23, 2026 13:47
miaulalala
miaulalala approved these changes Jun 30, 2026
View reviewed changes

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all changes implemented

@nickvergessen nickvergessen mentioned this pull request Jul 1, 2026
Closed
1 task
@miaulalala

miaulalala commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@ArtificialOwl your review would be apprechiated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend
@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst
@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl
@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner
@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner
@artonge artonge Awaiting requested review from artonge
@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review Waiting for reviews backport-request community pull requests from community feature: federation feedback-requested pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.