Repository navigation
Conversation
OCA.Viewer is gone in Nextcloud 36. Ask the viewer library whether it shows the file, and open it alone rather than with its folder. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommendations opened files through
OCA.Viewer, which is gone in Nextcloud 36. It now uses@nextcloud/viewer:canView()decides whether the viewer shows the file, andopen()gets the recommended file alone. Opening it with its folder gave the viewer previous and next files that had nothing to do with the recommendation.Fixes #1174
Fixes #325
Tried on master: a recommended picture opens in the viewer from the Files list. Not tried from the dashboard widget. The app has no JS tests to extend.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.