Repository navigation
fix: register the app menu entry in PHP so "Office" isn't translated - #200
Open
juliusknorr with Copilot wants to merge 1 commit into
Open
juliusknorr with Copilot wants to merge 1 commit into
juliusknorr with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix app name translation to retain product name
fix: register the app menu entry in PHP so "Office" isn't translated
Oct 14, 2026
juliusknorr
marked this pull request as ready for review
October 14, 2026 18:21
…ated Assisted-by: GitHubCopilot:copilot-swe-agent Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
force-pushed
the
copilot/fix-translated-app-name
branch
from
October 15, 2026 06:37
17aaabb to
9ccce57
Compare
juliusknorr
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigation name in
info.xmlis extracted to Transifex, so the product name "Office" got translated (e.g. "Büro"). The<navigations>block is removed and the entry is now registered viaINavigationManagerin a newLoadNavigationEntryListeneronLoadAdditionalEntriesEvent(same approach as spreed), with an untranslated name and the same route, icon and type.Notes:
order => 10is new, the old entry had none."Office"translations can only be cleaned up in Transifex, since the top-level<name>is still extracted.Fixes #17