Repository navigation
fix(web-push): improve fetching notifications with web-push - #3549
Merged
Merged
Conversation
nickvergessen
approved these changes
Oct 29, 2026
Collaborator
Author
|
/backport! to stable35 |
Collaborator
Author
|
/backport! to stable34 |
Collaborator
Author
|
/compile |
Collaborator
Author
|
/compile rebase |
Web push activation set hasNotifyPush, so every later web push skipped the fetch. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
The server sends the activation push only for a new subscription. On later page loads onActivated was never called, so polling stayed at the default interval. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
If the app mounts after the load event, the listener never fired. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/noid/web-push
branch
from
October 29, 2026 13:36
02af1d9 to
91f51d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minor web-push handling issues:
hasNotifyPushflag, so every onPush event skipped the new list fetch.🤖 AI (if applicable)