Skip to content

[stable34] fix(web-notifications): open notification link in a new tab #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Oct 29, 2026
Merged

[stable34] fix(web-notifications): open notification link in a new tab #3547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af38085
fix(web-notifications): open notification link in a new tab
Antreesy Oct 28, 2026
9ee84f8
chore(assets): Recompile assets
nextcloud-command Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion js/NotificationsApp-CQOkfsz6.chunk.mjs.map
View file
Open in desktop

This file was deleted.

26 changes: 13 additions & 13 deletions js/NotificationsApp-CQOkfsz6.chunk.mjs → js/NotificationsApp-DunflKne.chunk.mjs
View file
Open in desktop

Large diffs are not rendered by default.

0 ...tificationsApp-CQOkfsz6.chunk.mjs.license → ...tificationsApp-DunflKne.chunk.mjs.license
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions js/NotificationsApp-DunflKne.chunk.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

0 ...cationsApp-CQOkfsz6.chunk.mjs.map.license → ...cationsApp-DunflKne.chunk.mjs.map.license
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions js/index-hmOgSUJr.chunk.mjs → js/index-DCT6BTsu.chunk.mjs
View file
Open in desktop

Large diffs are not rendered by default.

0 js/index-hmOgSUJr.chunk.mjs.license → js/index-DCT6BTsu.chunk.mjs.license
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion js/index-hmOgSUJr.chunk.mjs.map → js/index-DCT6BTsu.chunk.mjs.map
View file
Open in desktop

Large diffs are not rendered by default.

0 js/index-hmOgSUJr.chunk.mjs.map.license → js/index-DCT6BTsu.chunk.mjs.map.license
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions js/notifications-main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('notifications', '', 'js/NotificationsApp-CQOkfsz6.chunk.mjs'),window.OC.filePath('notifications', '', 'js/_plugin-vue_export-helper-BEEBXb8F.chunk.mjs'),window.OC.filePath('notifications', '', 'js/style-CTrgl3U_.chunk.mjs'),window.OC.filePath('notifications', '', 'css/style-KKPrO-hg.chunk.css'),window.OC.filePath('notifications', '', 'css/_plugin-vue_export-helper-DZYRV3dZ.chunk.css'),window.OC.filePath('notifications', '', 'js/vite-preload-helper-DxYC2qmj.chunk.mjs'),window.OC.filePath('notifications', '', 'js/mdi-CpchYUUV-BTMM3-Z9.chunk.mjs'),window.OC.filePath('notifications', '', 'js/BrowserStorage-BnMuhqUG.chunk.mjs'),window.OC.filePath('notifications', '', 'css/NotificationsApp-BbUtg1TL.chunk.css')])))=>i.map(i=>d[i]);
import{_ as o}from"./vite-preload-helper-DxYC2qmj.chunk.mjs";import{c as i,d as n}from"./style-CTrgl3U_.chunk.mjs";const m=n(()=>o(()=>import("./NotificationsApp-CQOkfsz6.chunk.mjs").then(t=>t.N),__vite__mapDeps([0,1,2,3,4,5,6,7,8]),import.meta.url));i(m).mount("#notifications");
const __vite__mapDeps=(i,m=__vite__mapDeps,d=(m.f||(m.f=[window.OC.filePath('notifications', '', 'js/NotificationsApp-DunflKne.chunk.mjs'),window.OC.filePath('notifications', '', 'js/_plugin-vue_export-helper-BEEBXb8F.chunk.mjs'),window.OC.filePath('notifications', '', 'js/style-CTrgl3U_.chunk.mjs'),window.OC.filePath('notifications', '', 'css/style-KKPrO-hg.chunk.css'),window.OC.filePath('notifications', '', 'css/_plugin-vue_export-helper-DZYRV3dZ.chunk.css'),window.OC.filePath('notifications', '', 'js/vite-preload-helper-DxYC2qmj.chunk.mjs'),window.OC.filePath('notifications', '', 'js/mdi-CpchYUUV-BTMM3-Z9.chunk.mjs'),window.OC.filePath('notifications', '', 'js/BrowserStorage-BnMuhqUG.chunk.mjs'),window.OC.filePath('notifications', '', 'css/NotificationsApp-BbUtg1TL.chunk.css')])))=>i.map(i=>d[i]);
import{_ as o}from"./vite-preload-helper-DxYC2qmj.chunk.mjs";import{c as i,d as n}from"./style-CTrgl3U_.chunk.mjs";const m=n(()=>o(()=>import("./NotificationsApp-DunflKne.chunk.mjs").then(t=>t.N),__vite__mapDeps([0,1,2,3,4,5,6,7,8]),import.meta.url));i(m).mount("#notifications");
//# sourceMappingURL=notifications-main.mjs.map
5 changes: 3 additions & 2 deletions src/services/webNotificationsService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ async function createWebNotification(notification) {
await emit('notifications:action:execute', event)

if (!event.cancelAction) {
console.debug('Redirecting because of a click onto a notification', notification.link)
window.location.href = notification.link
console.debug('Opening a new tab because of a click onto a notification', notification.link)
window.open(notification.link, '_blank')
return
}

// Best effort try to bring the tab to the foreground (works at least in Chrome, not in Firefox)
Expand Down
Loading