fix(comments): register event listener for typed comment events#7894
Open
miaulalala wants to merge 1 commit intomainfrom
Open
fix(comments): register event listener for typed comment events#7894miaulalala wants to merge 1 commit intomainfrom
miaulalala wants to merge 1 commit intomainfrom
Conversation
miaulalala
requested review from
juliusknorr and
samin-z
and removed request for
grnd-alt and
luka-nextcloud
Since the typed comment events (CommentAddedEvent, CommentUpdatedEvent, etc.) were introduced in NC34, dispatchTyped() dispatches using the exact subclass name. Registering only for CommentsEvent::class means the listener never fires, so comment mentions in Deck cards never create notifications or activity entries. Update tests to use typed events directly, matching how Manager now dispatches them. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/comments-event-listener-registration-new
branch
from
951459a to
4b48d24
Compare
Contributor
|
🐢 Performance warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the typed comment events (CommentAddedEvent, CommentUpdatedEvent, etc.) were introduced in NC34, dispatchTyped() dispatches using the exact subclass name. Registering only for CommentsEvent::class means the listener never fires, so comment mentions in Deck cards never create notifications or activity entries.
Update tests to use typed events directly, matching how Manager now dispatches them.
Changes were introduced in nextcloud/server#56076
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
Checklist