Avoid occ circles:check from failing because of outdated cache values#2568
Open
salmart-dev wants to merge 1 commit into
Open
Avoid occ circles:check from failing because of outdated cache values#2568salmart-dev wants to merge 1 commit into
occ circles:check from failing because of outdated cache values#2568salmart-dev wants to merge 1 commit into
Conversation
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
salmart-dev
force-pushed
the
fix/circles-check-apcu
branch
from
05ad1ea to
a88f3ce
Compare
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport! to stable33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
occ circles:checkcommand sets and reads values fromIAppConfig, and so does the service called by it, to perform checks.During the loopback check, the code sets the value in the app config for a dummy token, before issuing a request that reads this value. Since the app config can use caches, when the local cache is set to APCu, the cache is not shared between CLI and HTTP workers. This results in random failures caused by the fact that a worker may receive the HTTP request and still hold the out-of-date config value.
Checklist
3. to review, feature component)stable32)AI (if applicable)