Skip to content

fix(occ): preserve ExApp deploy options on update#839

Merged
oleksandr-nc merged 1 commit intomainfrom
fix/preserve-deploy-options-on-update
Apr 24, 2026
Merged

fix(occ): preserve ExApp deploy options on update#839
oleksandr-nc merged 1 commit intomainfrom
fix/preserve-deploy-options-on-update

Conversation

@oleksandr-nc
Copy link
Copy Markdown
Contributor

Fixes #808.

Update.php reads ex_deploy_options without an appId filter. formatDeployOptions() then flattens by type, so whichever app's row comes last in iteration order clobbers the rest and the target app's saved env vars get dropped whenever another ExApp has rows in the table.

Tests: unit coverage in ExAppDeployOptionsServiceTest, a Docker integration job in tests-deploy.yml, and a K8s integration step in test_occ_commands_k8s.py that runs across all four expose-type workflows.

@oleksandr-nc oleksandr-nc marked this pull request as draft April 21, 2026 18:39
@oleksandr-nc oleksandr-nc force-pushed the fix/preserve-deploy-options-on-update branch 3 times, most recently from 00653e6 to 413ad4b Compare April 23, 2026 13:52
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com>
@oleksandr-nc oleksandr-nc force-pushed the fix/preserve-deploy-options-on-update branch from 413ad4b to f288123 Compare April 23, 2026 14:23
@oleksandr-nc oleksandr-nc marked this pull request as ready for review April 23, 2026 16:23
@oleksandr-nc oleksandr-nc requested a review from kyteinsky April 23, 2026 16:23
Copy link
Copy Markdown
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oleksandr-nc oleksandr-nc merged commit 32290fd into main Apr 24, 2026
51 checks passed
@oleksandr-nc oleksandr-nc deleted the fix/preserve-deploy-options-on-update branch April 24, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExApp upgrade fails to carry forward the previously set environment variables

2 participants