Skip to content

Prepare 2.0.0-beta.10 - #44

Merged
skjnldsv merged 1 commit into
mainfrom
chore/prepare-2.0.0-beta.10
Sep 17, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
chore/prepare-2.0.0-beta.10

Conversation

@skjnldsv

Copy link
Copy Markdown
Contributor

One fix since beta.9, and the server needs it: #43, which stops the viewer re-opening over itself while it closes.

Closing unwinds the history entries the viewer pushed, and until history.go() lands the URL still says openfile=true, which is the flag the Files list opens a file for. On a shared CI runner that window is wide enough to hit: three media tests in nextcloud/server#63954 failed their close assertion with two modal containers in the DOM, one per viewer.

Cutting this lets that PR pick the fix up rather than working around it in its test harness.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added status: review Waiting for reviews AI assisted labels Sep 17, 2026
@skjnldsv
skjnldsv merged commit 1c56730 into main Sep 17, 2026
13 checks passed
@skjnldsv
skjnldsv deleted the chore/prepare-2.0.0-beta.10 branch September 17, 2026 20:18
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.99%. Comparing base (b23defd) to head (023e33f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   87.99%   87.99%           
=======================================
  Files          36       36           
  Lines        2508     2508           
  Branches      525      525           
=======================================
  Hits         2207     2207           
  Misses        297      297           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant