Update dependencies, image editor 1.0.0-beta.4 included - #41
Merged
Merged
Conversation
The editor beta brings the export quality fix and the threading work: a JPEG is written at the quality its source was written at, and the decode and the mipmap levels happen in a worker. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 36 36
Lines 2507 2507
Branches 524 524
=======================================
Hits 2206 2206
Misses 297 297
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nextcloud/image-editor1.0.0-beta.4, and the lockfile refreshed for everything already in range:@nextcloud/files4.1.0,@nextcloud/router3.2.0,@nextcloud/vue9.13.0, vue 3.5.43, plus a handful of dev packages.The editor beta is the part worth knowing about. A JPEG is now written at the quality its source was written at rather than the browser's default, which on a 12 Mpx photo saved at quality 97 moves an edit from 38.1 dB PSNR and 5.41 MB to 46.0 dB and 7.42 MB. And the decode and the half-size copies the scene draws from happen in a worker now, so opening that photo on a phone-class CPU went from 6.1 s to 0.9 s with the longest blocked frame down from 5.1 s to 0.4 s.
Note
That threading change alters how the editor loads a URL source: it fetches the bytes rather than assigning them to an
<img>, because the worker needs bytes to decode. The cross-origin rules are the ones the editor already applied, and anything that fails falls back to the old path. The viewer hands the editor a URL, soopens a file whose source is a plain URLin the e2e is the test that covers it, and it passes.Majors left alone for their own PRs: vitest 5, vite 8, typescript 7, jsdom 29.
Lint, typecheck, 314 unit tests, build, the 10 kB size budget (6.8 kB gzipped) and the published-imports check all pass, along with the 12 e2e in both browsers.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.