Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/models.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ describe('images model', () => {
})

it('rejects a preview-only mime when no preview provider is enabled', async () => {
// enabled_preview_providers is empty (no initial-state), so image/heic is filtered out.
// No preview capability in this suite, so image/heic is filtered out.
const { registerImageHandler } = await import('../lib/models/images.ts')
registerImageHandler()
const handler = handlerById('images')
Expand Down
48 changes: 48 additions & 0 deletions __tests__/previewProviders.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*!
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { getHandlers } from '../lib/index.ts'
import { makeFile } from './factories.ts'

const { capabilities } = vi.hoisted(() => ({ capabilities: { value: {} as object } }))
vi.mock('@nextcloud/capabilities', () => ({ getCapabilities: () => capabilities.value }))

/**
* Register the image handler against the given set of enabled preview providers.
*
* @param providers - The provider mime patterns the server would report
*/
async function registerWithProviders(providers?: string[]) {
capabilities.value = providers === undefined ? {} : { core: { previews: { enabled_providers: providers } } }
vi.resetModules()
const { registerImageHandler } = await import('../lib/models/images.ts')
registerImageHandler()
return getHandlers().get('images')!
}

describe('preview providers', () => {
beforeEach(() => {
capabilities.value = {}
})

it('enables a preview-only mime the server has a provider for', async () => {
const handler = await registerWithProviders(['/image\\/hei(f|c)/'])

expect(handler.enabled([makeFile({ mime: 'image/heic' })])).toBe(true)
})

it('leaves a preview-only mime alone when its provider is disabled', async () => {
const handler = await registerWithProviders(['/image\\/jpeg/'])

expect(handler.enabled([makeFile({ mime: 'image/heic' })])).toBe(false)
})

it('falls back to the browser mimes when the capability is missing', async () => {
const handler = await registerWithProviders(undefined)

expect(handler.enabled([makeFile({ mime: 'image/heic' })])).toBe(false)
expect(handler.enabled([makeFile({ mime: 'image/png' })])).toBe(true)
})
})
12 changes: 10 additions & 2 deletions lib/models/images.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,21 @@
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { loadState } from '@nextcloud/initial-state'
import { getCapabilities } from '@nextcloud/capabilities'
import { defineCustomElement } from 'vue'
import { registerHandler } from '../index.ts'
import { logger } from '../services/logger.ts'
import { t } from '../utils/l10n.ts'

const enabledPreviewProviders = loadState<string[]>('viewer', 'enabled_preview_providers', [])
interface PreviewCapabilities {
core?: {
previews?: {
enabled_providers?: string[]
}
}
}

const enabledPreviewProviders = (getCapabilities() as PreviewCapabilities).core?.previews?.enabled_providers ?? []

/**
* Those mimes needs a proper preview to be displayed
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@
},
"peerDependencies": {
"@nextcloud/axios": "^2.5.2",
"@nextcloud/capabilities": "^1.2.1",
"@nextcloud/dialogs": "^7.5.0",
"@nextcloud/event-bus": "^3.3.3",
"@nextcloud/files": "^4.0.0",
"@nextcloud/initial-state": "^3.0.0",
"@nextcloud/l10n": "^3.4.1",
"@nextcloud/paths": "^3.1.0",
"@nextcloud/router": "^3.1.0",
Expand All @@ -75,11 +75,11 @@
},
"devDependencies": {
"@nextcloud/axios": "^2.5.2",
"@nextcloud/capabilities": "^1.2.1",
"@nextcloud/dialogs": "^7.5.0",
"@nextcloud/eslint-config": "^9.0.1",
"@nextcloud/event-bus": "^3.3.3",
"@nextcloud/files": "^4.0.0",
"@nextcloud/initial-state": "^3.0.0",
"@nextcloud/l10n": "^3.4.1",
"@nextcloud/paths": "^3.1.0",
"@nextcloud/router": "^3.1.0",
Expand Down
Loading