Receive agent commands via metric_data response instead of polling - #3087
Draft
nr-csantos wants to merge 1 commit into
Draft
Receive agent commands via metric_data response instead of polling#3087nr-csantos wants to merge 1 commit into
nr-csantos wants to merge 1 commit into
Conversation
Stops making a dedicated get_agent_commands collector RPC every harvest
cycle. The collector now returns any pending agent commands as the
return_value of metric_data (same [[id, {name, arguments}], ...] shape),
so this eliminates one HTTP round-trip per harvest for the common case
where there's nothing to do.
RPMService caches the commands returned by metric_data, and CommandParser
now processes them from afterHarvest() instead of beforeHarvest(), so
commands from a harvest's metric_data response are handled in that same
cycle with no added latency.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Stops making a dedicated get_agent_commands collector RPC every harvest cycle. The collector now returns any pending agent commands as the return_value of metric_data (same [[id, {name, arguments}], ...] shape), so this eliminates one HTTP round-trip per harvest for the common case where there's nothing to do.
RPMService caches the commands returned by metric_data, and CommandParser now processes them from afterHarvest() instead of beforeHarvest(), so commands from a harvest's metric_data response are handled in that same cycle with no added latency.
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks