docs(claude-md): partner pages come in two shapes; Mintlify PR previews are currently absent - #406
Conversation
…ws are currently absent Records what docs#400 (Baselayer) established: a partner page's shape is decided by the plan's billingModel (pay-as-you-go vs credits), the three edits every partner page needs, and the id check that would have caught a copied org id. Also notes that the Mintlify preview deployment step has produced nothing since #386, so the working preview is `mintlify dev`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MySF9EHpweChiXdMHw2caQ
|
👀 Reviewing this now. |
eruizgar91
left a comment
eruizgar91
left a comment
There was a problem hiding this comment.
Reviewed the CLAUDE.md-only follow-up to #400: the two-shapes table, the three-edit checklist, and the Mintlify-preview note. Everything factual in it was checked against the live pages, the plan documents and the repo's own check-run history rather than taken at face value.
6 findings, all inline: 2 MEDIUM, 4 LOW. None blocks — this is an instruction file, not shipped content — but the MEDIUMs are the kind that get acted on confidently.
The three-edit checklist is complete and correct. Verified against all three partner-page PRs, not just #400: #266 (Exa), #309 (You.com) and #400 (Baselayer) each touched exactly docs.json, integrations/<partner>.mdx and solutions/api-providers.mdx — no fourth edit in any of them. The Protocols & Partners group name is right (docs.json:163, with all three pages listed), and each partner does have its own paragraph plus guide link under Featured providers. architecture.md was considered as a candidate fourth edit and discarded: it lists no per-partner page and none of the three PRs touched it (the file's own "Review Checklist" line - [ ] architecture.md is updated is a pre-existing looseness, not something this PR introduces).
The two-shapes description is right about mechanics and wrong about which page is which shape. The PAYG mechanic (one token → one POST → a key that then works alone) matches exa.mdx and youdotcom.mdx; the credits mechanic (token on every call, key alongside, no returning-payer/replayed-token contract) matches baselayer.mdx. But the stated decision procedure — read billingModel off the plan document — returns credits for Exa's plan, so the rule and its own example table disagree (finding 1), and two of the three credits markers are present on PAYG pages too (finding 3).
The Mintlify claim holds in substance, with the boundary off by one PR and a cause attributed further than the evidence reaches (findings 4 and 6). The actionable half is present — "the preview is mintlify dev locally" — but three other instructions in the same file still direct authors to a preview link (finding 5).
Also checked and clean: no secret, token or internal-only URL (api.live.nevermined.app is the public API and is already all over the published pages); no broken internal reference (integrations/exa.mdx, youdotcom.mdx, baselayer.mdx, solutions/api-providers.mdx and the docs.json group all exist at this head); nothing that contradicts #400's own page. The #386 issue reference is fine here: the repo's "never leak an issue ref into a published string" concern does not bind, because CLAUDE.md appears in no docs.json route and there is no .mintignore — it is not in Mintlify's content set. One thing not worth a finding but worth knowing: "check every id on the page … against the plan document's orgId" is vacuous for Exa, whose plan returns orgId: null — a partner without an org has nothing to check against.
Verdict is not mine to send; posted as a verdict-less comment review.
eruizgar91
left a comment
eruizgar91
left a comment
There was a problem hiding this comment.
🟡 Approved with comments — no blockers; 2 should-fix, 4 nit(s) left inline.
Inline review: #406 (review)
…ingModel; preview note corrected Review round 1 (docs#406): Exa's plan is `credits` with amount=min=max=1, so a rule keyed on billingModel alone lands an Exa-shaped merchant on the metered template. The discriminator is how many settles one purchase funds (plus registry.credits), youdotcom.mdx is named the buy-once reference (exa.mdx lacks the REST section, the double-charge warning, Pricing and the agentic-instructions link), and the credits-row markers are reworded to what is actually shape-specific. Preview note: last success was #389 not #386, production deploys from main are unaffected, and the cause is not established; the three other preview instructions in the file now point at the note. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MySF9EHpweChiXdMHw2caQ
2 participants
Summary
CLAUDE.mdfollow-up to #400 (Baselayer), so the next partner page doesn't repeat what that one had to discover:billingModel(pay-as-you-go→ Exa/You.com;credits→ Baselayer: token on every call, Cost line per metered endpoint, lot-size pricing), plus the three-edit checklist (page ·docs.jsongroup · Featured providers) and the id check — a draft copied You.com's org id into Baselayer's agentic-instructions link.mintlify dev.No content pages touched. Decision record:
~/code/notes/decisions/docs/0004(private KB).🤖 Generated with Claude Code
https://claude.ai/code/session_01MySF9EHpweChiXdMHw2caQ