-
Notifications
You must be signed in to change notification settings - Fork 0
docs(orders): remove the not-yet-GA banner #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ NICE — Splitting the banner's two jobs and keeping the audience gate is the right call
Worth naming because it's the part that could easily have gone wrong. The removed
<Warning>was doing two different jobs: a temporal hedge ("not enabled in production yet") and an audience gate ("being rolled out to organization accounts"). Only the first is now false.The second survives exactly where it belongs — Prerequisites, :26, untouched by this PR:
And that matches the implementation rather than merely sounding right.
apps/api/src/orders/order-env.tssays so in its header: "Eligibility to create orders is gated on active-organization membership (#3313), not an env var; these knobs are the per-merchant caps…" — so there is no global on/off flag whose state could contradict the page; the restriction is per-caller and is documented as such.The sweep is also complete:
not yet generally available/not-yet-GA/pre-GA/not enabled in production/rolled out to organizationreturn zero matches repo-wide after this change,.md/.mdx/.jsonalike. And dropping "While Orders is pre-GA" from the tutorial sentences while keeping the local-stack fact is the safer direction — a wrong reason would have been worse than none.Anchored at line 64; the finding refers to
integrate/patterns/orders.mdx:63, which is outside this PR's diff hunks.🤖 pr-review-toolkit · direct-verification · high