Skip to content

feat: add missing commit_sha, draft, review_id to CreateSiteBuild - #668

Merged
serhalp merged 1 commit into
masterfrom
serhalp/ex-3448-cli-netlify-deploy-remote-for-pushed-commits-on-forge-sites
Oct 22, 2026
Merged

serhalp merged 1 commit into
masterfrom
serhalp/ex-3448-cli-netlify-deploy-remote-for-pushed-commits-on-forge-sites

Conversation

@serhalp

@serhalp serhalp commented Oct 22, 2026

Copy link
Copy Markdown
Member

These were undocumented. There doesn't appear to be any reason for them to be private.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: a478c1dc-51a0-4ee0-83e5-0bd156ba75b0
📥 Commits

Reviewing files that changed from the base of the PR and between 3928aef and 93b593f.

📒 Files selected for processing: 2
  • go/plumbing/operations/create_site_build_parameters.go
  • swagger.yml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

📝 Summary

Summary by CodeRabbit

  • New Features
    • Site builds can now optionally target a specific commit, be requested as draft deploys, or be associated with a merge or pull request to create a deploy preview.
    • Builds for a merge or pull request are always drafts. Commit and review selections do not apply to zip uploads.

The build operation adds optional commit_sha, draft, and review_id query parameters to the API definition and Go request parameters. The Go request parameter type provides fluent and setter methods for these fields. WriteToRequest adds applicable values to the query and returns errors from query-setting operations.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: paulo

Merge Risk: ⚪ Minimal · up to 93b59

The new build parameters appear ready to merge after normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the addition of the three missing parameters to CreateSiteBuild. It is concise and matches the main change.
Description check Passed The description explains that the parameters were undocumented and should be exposed. It is directly related to the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for open-api ready!

Name Link
🔨 Latest commit 93b593f
🔍 Latest deploy log https://app.netlify.com/projects/open-api/deploys/6ada53a9a0b56d8d9ee0282a
😎 Deploy Preview https://deploy-preview-668--open-api.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@serhalp
serhalp force-pushed the serhalp/ex-3448-cli-netlify-deploy-remote-for-pushed-commits-on-forge-sites branch from 29a8383 to d0a5985 Compare October 22, 2026 18:19
@serhalp
serhalp force-pushed the serhalp/ex-3448-cli-netlify-deploy-remote-for-pushed-commits-on-forge-sites branch from d0a5985 to 93b593f Compare October 22, 2026 18:19
@serhalp
serhalp marked this pull request as ready for review October 22, 2026 18:19
@serhalp
serhalp requested review from a team as code owners October 22, 2026 18:19
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-22T18:19:39.606373Z
We couldn’t complete this review. Comment @codex review to try again.
93b593f Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@serhalp
serhalp merged commit a94f056 into master Oct 22, 2026
21 checks passed
@serhalp
serhalp deleted the serhalp/ex-3448-cli-netlify-deploy-remote-for-pushed-commits-on-forge-sites branch October 22, 2026 20:38
serhalp pushed a commit that referenced this pull request Oct 22, 2026
🤖 I have created a release *beep* *boop*
---


##
[2.62.0](v2.61.0...v2.62.0)
(2026-10-22)


### Features

* add missing `commit_sha`, `draft`, `review_id` to CreateSiteBuild
([#668](#668))
([a94f056](a94f056))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com>
Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants