Skip to content

Fix Previous PR - #436

Merged
thiagoftsm merged 3 commits into
netdata:masterfrom
thiagoftsm:fix_previous_pr
Oct 26, 2026
Merged

thiagoftsm merged 3 commits into
netdata:masterfrom
thiagoftsm:fix_previous_pr

Conversation

@thiagoftsm

@thiagoftsm thiagoftsm commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor
Summary

With previous PR some binaries were removed from release. This PR address this issue.

Test Plan
  1. Get binaries according to your C library from [this](ADD ACTIONS LINK HERE) link and extract them inside a directory, for example: ../artifacts.
    You can also get everything for glibc [here](UPLOAD FILE WITH ALL BINARIES TO SIMPLIFY REVIEWERS).

  2. Extract them running:

    $ for i in `ls *.zip`; do unzip $i; rm .gitkeep ; rm $i; done
    $ for i in `ls *.tar`; do tar -xf $i; rm $i* ; done
  3. Compile branch an run the following tests:

    # make clean; make tester
    # for i in `seq 0 3`; do ./tests/legacy_test --netdata-path ../artifacts --content --iteration 1 --pid $i --log-path file_c_pid$i.txt; done
    # for i in `seq 0 3`; do ./gotests/go_tester --netdata-path ../artifacts --content --iteration 1 --pid $i --log-path file_go_pid$i.txt; done
  4. Every test should ends with Success, unless you do not have a specific target (function) available.

Additional information

This PR was tested on:

Linux Distribution Environment Kernel Version
Slackware Current Bare metal 7.2.8
Slackware current VM 6.18.34
Debian 13 VM 6.12.107+deb13
Alma 9 VM 5.14.0-687.57.1.el9_8
Slackware Current VM 5.10.256
Alma 8 VM 4.18.0-553.174.1.el8_10
Slackware Current VM 5.4.302

@thiagoftsm
thiagoftsm requested a review from Ferroin as a code owner October 25, 2026 23:07
@thiagoftsm
thiagoftsm merged commit 4b11806 into netdata:master Oct 26, 2026
55 checks passed
@thiagoftsm
thiagoftsm deleted the fix_previous_pr branch October 26, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants