Skip to content

[agent-network] Document the provider save-time check - #947

Open
mlsmaycon wants to merge 1 commit into
agent-network/live-model-discoveryfrom
agent-network/provider-credential-check
Open

[agent-network] Document the provider save-time check#947
mlsmaycon wants to merge 1 commit into
agent-network/live-model-discoveryfrom
agent-network/provider-credential-check

Conversation

@mlsmaycon

Copy link
Copy Markdown
Contributor

Docs for netbirdio/netbird#7301 (backend) and netbirdio/dashboard#772 (UI), which check a provider's upstream URL and credential against the vendor before storing them.

Stacked on #945 — it adds the Load Models from the Provider section this one refers to, and both edit providers.mdx. Retarget to main once #945 merges.

What changed

Step 6 of Connect a Provider now says saving is checked, and a new The Save-Time Check subsection sits under it covering what the steps cannot say in one line:

  • Which of the two fields a refusal names, and that the form keeps what you typed.
  • That an edit is only re-checked when the Upstream URL or the API key moves — renames, model rows and price edits save without asking the vendor anything.
  • That a URL-only change is tested against the stored credential, since the key never returns to the browser.
  • That a rejected key never replaces a working one.

The list of what isn't checked is the part worth getting right: an operator whose provider saved without a word should be able to see why it was exempt rather than assume the check silently passed. Three cases — providers that publish no listing NetBird can ask for, a Bedrock record pointed at a proxy or self-hosted endpoint rather than an AWS runtime host, and any upstream on a private address that the agents reach through the tunnel but the management service cannot reach at all.

A <Note> covers the vendor-outage case, since "the provider returned an error" is the one message that names neither of the operator's own fields and the right response is to wait rather than to edit anything.

Not included

No screenshot. The refusal state is worth one eventually — the modal staying open with the message against the form — but I can't produce it. Happy to merge as-is and follow up.

Validation

npm run lint:mdx — 293 files, no heading hierarchy violations.

I did not run npm run build; flagging that rather than implying otherwise. One anchor was removed rather than guessed at: linking to Custom & Self-hosted Providers needs a slug for a heading containing &, and nothing else in the repo links to such a heading, so there was no precedent to copy. The bullet reads fine without it.


Generated by Claude Code

Saving a provider now asks the vendor whether its url and credential work, and
refuses the record if they do not. That changes what the Connect a Provider
steps promise, so step 6 says so and a new subsection covers the rest: which of
the two fields a refusal names, that an edit is only re-checked when the url or
the key moves, that a url-only change is tested against the stored credential,
and that a rejected key never replaces a working one.

The list of what is not checked is the part worth getting right — an operator
whose provider saved without a word should be able to see why. It covers the
providers that publish no listing, a Bedrock record pointed somewhere AWS does
not own, and any upstream on a private address, which the agents reach through
the tunnel and the management service cannot reach at all.
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 24, 2026 7:49am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d75e159-1f0d-4c3b-a1d1-9033c193dd7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant