fix: use --restart=unless-stopped instead of --rm in Docker install command - #760
fix: use --restart=unless-stopped instead of --rm in Docker install command#760shaban00 wants to merge 1 commit into
Conversation
…ommand The generated Docker command used --rm, which removes the container on stop. Combined with -d, the NetBird client would not survive a host reboot despite the persistent netbird-client volume. Replace with --restart=unless-stopped so the client reconnects automatically.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Docker run command now uses ChangesDocker restart policy
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The generated Docker install command changes its container lifecycle policy to preserve the client across host restarts. No actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @shaban00 thanks for the contribution, will be merging this before EOW |
The generated Docker command used --rm, which removes the container on stop. Combined with -d, the NetBird client would not survive a host reboot despite the persistent netbird-client volume. Replace with --restart=unless-stopped so the client reconnects automatically.
Issue ticket number and link
Documentation
Select exactly one:
Summary by CodeRabbit