Add legacy desktop app options to the Linux install instructions - #751
Add legacy desktop app options to the Linux install instructions#751pappz wants to merge 2 commits into
Conversation
The desktop app ships in two mutually-exclusive builds: the current one links GTK 4.14+ and WebKitGTK 6.0, and a legacy one links GTK 3 and WebKit2GTK 4.1 for releases without WebKitGTK 6.0. Both use the netbird-ui package name, so the legacy build is served from its own repository path. Add the two distro options that need it. The CLI still comes from the regular repository, so both are registered. On Ubuntu the legacy desktop app needs the universe component, enabled behind an ID check because `universe` is an Ubuntu-only shortcut that Debian rejects. On RHEL 9 the EPEL repository is still required, since it provides WebKit2GTK 4.1.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughLinuxTab.tsx adds an APT installation option for Ubuntu 22.04 and Debian 12. The option configures the stable repository, enables Ubuntu ChangesLegacy APT installation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds legacy Linux desktop-app installation options without evidence of a concrete correctness or production-impact risk; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/modules/setup-netbird-modal/LinuxTab.tsxOops! Something went wrong! :( ESLint: 9.39.5 TypeError: Converting circular structure to JSON Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/modules/setup-netbird-modal/LinuxTab.tsx`:
- Around line 60-71: Pin every legacy GTK3 netbird-ui installation to the GTK3
package source: in src/modules/setup-netbird-modal/LinuxTab.tsx lines 60-71,
retain YUM_GTK3_REPOSITORY and make the rhel-gtk3 DNF transaction prefer
netbird-gtk3 or disable the regular netbird repository; in lines 100-115, update
the APT installation to target the gtk3 suite explicitly; and in lines 143-150,
apply the same explicit DNF selection to the RHEL 9 GTK3 path.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d63a4dc9-00f1-4652-9a75-abb133c3bc5b
📒 Files selected for processing (1)
src/modules/setup-netbird-modal/LinuxTab.tsx
The GTK3 build shipped under its own netbird-ui-gtk3 name with Conflicts/Replaces on netbird-ui, so it coexists with the current build in the regular repository. The separate repository paths the previous commit assumed were never created: dists/gtk3 and yum-gtk3/$basearch both 404, and the yum repository is flat rather than per-basearch. Drop them and install netbird-ui-gtk3 from the regular repository instead. Verified in Docker that the rendered commands install netbird 0.77.0 and netbird-ui-gtk3 0.77.0 on Ubuntu 22.04 and Debian 12. Remove the RHEL 9 option: the RPM requires webkit2gtk4.1 (or libwebkit2gtk-4_1-0), but RHEL 9 only ships webkit2gtk3, which provides the 4.0 API, and EPEL does not carry 4.1 either, so dnf cannot resolve it. The general RHEL entry already directs version 9 users to the CLI. The desktop app is published for x86_64 only, which the install step already notes for every distribution that offers it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 participant
The desktop app ships in two mutually-exclusive builds: the current one links GTK 4.14+ and WebKitGTK 6.0, and a legacy one links GTK 3 and WebKit2GTK 4.1 for releases without WebKitGTK 6.0. Both use the netbird-ui package name, so the legacy build is served from its own repository path.
Add the two distro options that need it. The CLI still comes from the regular repository, so both are registered. On Ubuntu the legacy desktop app needs the universe component, enabled behind an ID check because
universeis an Ubuntu-only shortcut that Debian rejects. On RHEL 9 the EPEL repository is still required, since it provides WebKit2GTK 4.1.Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__
E2E tests
Optional: override the image tags used by the Playwright e2e workflow.
Defaults to
mainwhen omitted.management-cloud-tag: main
reverse-proxy-tag: main
Summary by CodeRabbit