Conversation
…on, single dashboard URL
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the parity gaps between Atlas Cloud in #618 and upstream 0.66.0:
CostSnapshot(with_balance), so it reaches balance formatting, Usage & Spend, and currency conversion. It was an untyped display string without a$.$95.50,$0.00,-$1.25) is kept alongside the typed value, becauseCostSnapshot::with_balanceclamps to>= 0and upstream preserves zero and negative balances (see the correction comment on Port Atlas Cloud balance provider from v0.66.0 #618).API, as upstream setsidentity.loginMethod = "API".https://www.atlascloud.ai/console.settings::api_keysnow readsatlascloud::DASHBOARD_URLinstead of carrying a second, disagreeing literal.ProviderIcon-atlascloud.svgglyph added to the frontend icon registry (fill switched from#000tocurrentColorso it tints with the brand color on the dark UI).No wire-shape change: the endpoint, envelope checks, and status mapping are unchanged.
Upstream reference
5cfe3f1f, feat(providers): add Atlas Cloud and Vercel balance plugins steipete/CodexBar#3917), v0.66.0.Sources/CodexBarCore/Resources/Plugins/atlascloud.js(row "Available balance" viactx.format.usd,identity.loginMethod = "API"),Sources/CodexBarCore/Providers/AtlasCloud/AtlasCloudProviderDescriptor.swift(dashboardURL),Sources/CodexBar/Resources/ProviderIcon-atlascloud.svg,Tests/CodexBarTests/APIBalancePluginTests.swift(zero and negative balances preserved).Ported / Deferred
Ported: typed balance, signed display row, login method, single dashboard URL, frontend icon, tests for
"-1.250000","0.00",""," ",NaN,1e999,0x10,"private-response", wrongobject/scope/currency, and HTTP 400/401/403/429/503 without echoing the body.Deferred:
docs/logos/atlascloud.svgand the embedded serve-dashboard icon (rust/src/cli/serve/dashboard/icons/): that table is pinned to the v0.48.0 white-glyph set and upstream's Atlas glyph is black, so the colour treatment needs a separate decision. The dashboard falls back to its neutral dot meanwhile.Retry-Afterhandling: upstream only forwards it as metadata and does not opt intoretryPolicy, so nothing to port.Validation
cargo +1.98.0 fmt --all: cleancargo +1.98.0 clippy --workspace --all-targets -- -D warnings: passcargo +1.98.0 test -p codexbar atlascloud -- --test-threads=4: 11 passedcargo +1.98.0 test -p codexbar -- --test-threads=4(full): 2275 passed, 0 failed, 1 ignoredpnpm exec vitest run providerIcons.test.ts TrayPanel.test.tsx: 31 passedpnpm run lint: pre-existing warnings only;pnpm run build: passAffected areas
rust/src/providers/atlascloud)UI proof
Pending: coordinator will capture CUA proof on a fresh build (tray card balance row and Atlas icon). Triage classed this port as not UI-affecting; the only visible change is the icon glyph and the
$balance text.