Skip to content

Port upstream 0.66.0: Atlas Cloud typed balance and parity (stacked on #618) - #676

Open
Finesssee wants to merge 1 commit into
codex/port-0.66.0-atlas-cloudfrom
port/micro-0.66.0-atlas-cloud-parity
Open

Finesssee wants to merge 1 commit into
codex/port-0.66.0-atlas-cloudfrom
port/micro-0.66.0-atlas-cloud-parity

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Summary

Closes the parity gaps between Atlas Cloud in #618 and upstream 0.66.0:

  • Balance is now a typed USD CostSnapshot (with_balance), so it reaches balance formatting, Usage & Spend, and currency conversion. It was an untyped display string without a $.
  • A signed display row "Available balance" ($95.50, $0.00, -$1.25) is kept alongside the typed value, because CostSnapshot::with_balance clamps to >= 0 and upstream preserves zero and negative balances (see the correction comment on Port Atlas Cloud balance provider from v0.66.0 #618).
  • Identity login method is API, as upstream sets identity.loginMethod = "API".
  • One canonical dashboard URL, https://www.atlascloud.ai/console. settings::api_keys now reads atlascloud::DASHBOARD_URL instead of carrying a second, disagreeing literal.
  • Upstream ProviderIcon-atlascloud.svg glyph added to the frontend icon registry (fill switched from #000 to currentColor so it tints with the brand color on the dark UI).

No wire-shape change: the endpoint, envelope checks, and status mapping are unchanged.

Upstream reference

Ported / Deferred

Ported: typed balance, signed display row, login method, single dashboard URL, frontend icon, tests for "-1.250000", "0.00", "", " ", NaN, 1e999, 0x10, "private-response", wrong object/scope/currency, and HTTP 400/401/403/429/503 without echoing the body.

Deferred:

  • docs/logos/atlascloud.svg and the embedded serve-dashboard icon (rust/src/cli/serve/dashboard/icons/): that table is pinned to the v0.48.0 white-glyph set and upstream's Atlas glyph is black, so the colour treatment needs a separate decision. The dashboard falls back to its neutral dot meanwhile.
  • Locale keys: no provider-specific UI strings were added, so there is nothing to translate.
  • Retry-After handling: upstream only forwards it as metadata and does not opt into retryPolicy, so nothing to port.

Validation

  • cargo +1.98.0 fmt --all: clean
  • cargo +1.98.0 clippy --workspace --all-targets -- -D warnings: pass
  • cargo +1.98.0 test -p codexbar atlascloud -- --test-threads=4: 11 passed
  • cargo +1.98.0 test -p codexbar -- --test-threads=4 (full): 2275 passed, 0 failed, 1 ignored
  • pnpm exec vitest run providerIcons.test.ts TrayPanel.test.tsx: 31 passed
  • pnpm run lint: pre-existing warnings only; pnpm run build: pass

Affected areas

  • Provider backend (rust/src/providers/atlascloud)
  • Settings API-key catalog (dashboard URL only)
  • Frontend icon registry (glyph asset only, no component change)
  • Tray / settings / float bar behavior

UI proof

Pending: coordinator will capture CUA proof on a fresh build (tray card balance row and Atlas icon). Triage classed this port as not UI-affecting; the only visible change is the icon glyph and the $ balance text.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 76e8e7c6-3ac2-4aae-b30d-25191d804d2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant