Skip to content

Port upstream 0.68.0: accept Venice Clerk session cookies with Bearer auth - #626

Open
Finesssee wants to merge 1 commit into
port/upstream-0.68.0from
port/micro-0.68.0-venice-clerk
Open

Finesssee wants to merge 1 commit into
port/upstream-0.68.0from
port/micro-0.68.0-venice-clerk

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Summary

Venice Web and Manual modes now accept Clerk session cookies (__session and __session_<non-empty suffix>). A Clerk value is sent as Authorization: Bearer <value> with no Cookie header; the legacy __venice-auth.session-token cookie (exact, then contiguous numbered chunks) keeps priority and is still sent as a Cookie header. Browser cookies are filtered after extraction to the exact venice.ai domain (dots trimmed, case-insensitive), because the shared extractor also returns subdomain cookies such as clerk.venice.ai __client. Missing-credential and invalid/expired-session errors use upstream's recovery text verbatim and are classified as sign-in / expired-session states.

Upstream reference

Ported / Deferred

Ported: cookie-name family, priority (legacy over Clerk, unsuffixed over first suffixed, last repeated __session wins), Bearer vs Cookie, exact-domain filter, error messages, and tests mirroring VeniceClerkSessionTests.
Deferred: upstream retries the next imported browser profile on a session-auth failure; the Windows extractor returns merged cookies for one lookup, so there is no per-profile list to retry. No Venice docs page exists in this repo, so the note that Web mode does not refresh unattended (Clerk sessions last about 60 s) lives only in the error text. The Settings source description in usageSourcePolicy.ts is unchanged (UI untouched).

Validation

  • cargo +1.98.0 fmt --all: clean
  • cargo +1.98.0 clippy --workspace --all-targets -- -D warnings: pass
  • cargo +1.98.0 test -p codexbar venice: 11 passed, 0 failed

Affected areas

Rust backend, Venice provider only (rust/src/providers/venice/mod.rs, +291/-39, 833 lines). No frontend, tray, settings, or dependency changes.

UI proof

Not applicable

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ec3fd9a3-ce68-43c8-90d7-9022e13114c2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant