Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
CI and review follow-up Fixed the rustfmt failure, then the next hosted failure in the Tauri command macro: async commands borrowing The focused frontend run also caught an existing assertion failure ( Verification: workspace clippy with warnings denied passed; 14 Rust currency tests and 40 focused frontend tests passed; the frontend production build and formatting checks passed. The two corrective changes received an independent thermo review with no blocker. These checks do not substitute for the complete feature's pending native Windows UI proof, so the PR remains draft. The branch also contains the merged #607 CI test corrections. The full CircleCI gate must pass on the updated head. |
Thermo-nuclear code-quality reviewVerdict: FINDINGS (blocking). Reviewed the full feature at head P1: The currency model is implemented twice, in Rust and in TypeScriptEach of these exists in both languages and has to be kept in sync by hand:
That's two fallback tables to update whenever a rate changes, and three copies of sanitizing. Suggested restructure: Rust owns the model, and the bridge carries the result. P1: The tray path skips the cache and reads from disk
P2: A second symbol table next to the canonical one
P2:
|
Port the v0.64.1 preferred display currency behavior, including TRY. A persisted preference controls presentation in Usage & Spend, tray labels, FloatBar, provider cost views, Claude Swap, and share PNGs. Conversion uses cached live rates with bundled fallback rates; copied and saved JSON exports retain source values.
The CI follow-up corrects Rust formatting and the Tauri async command return type. It also preserves non-currency unit labels such as
Creditswhen conversion is unavailable, as required by an existing regression test.Validation:
cargo fmt --all --checkandgit diff --check: passed.cargo clippy --workspace --all-targets -- -D warnings: passed on Windows.cargo test --workspace currency -- --test-threads=4: 14 passed across backend and Tauri.currency,usageSpendSharing,GeneralTab, andClaudeSwapAccountsSection: 40 passed.pnpm --dir apps/desktop-tauri build: locale check, TypeScript, and Vite build passed.This remains a draft pending a fresh Windows desktop build and native UI proof of the complete feature.