Export text telemetry values to CSV - #53
Open
CAOShurong wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41.
Text telemetry was present in the session and JSON export, but the CSV loop only wrote values accepted by
isFinite. Every string therefore produced an empty cell even though its column header was included.This change gives CSV cells one formatter: finite numbers keep the selected decimal separator, text values are emitted, embedded quotes are escaped according to CSV rules, and missing or non-finite numeric values remain empty. It also adds a focused regression test covering mixed numeric/text timestamps, comma-containing and quoted text, comma decimals, and invalid numeric data.
Validation:
main(25b91ac): a text column namedstatewas exported, but bothwarmingandreadyvalues were absent.npm run test:csvpassed on Node 25.9.0.|ttext telemetry packets over UDP, then used headless Chromium to export from the loaded web UI. The downloaded CSV contained both numeric values and both text values, includingready, "steady"with correct CSV escaping; the page reported no console or runtime errors.npm pack --dry-run --jsoncompleted and included the regression test.This is independent of #52 and does not change serial input handling.