exclude inactive records from default volunteer and opportunity views - #929
Open
ivannissimrch wants to merge 3 commits into
Open
exclude inactive records from default volunteer and opportunity views#929ivannissimrch wants to merge 3 commits into
ivannissimrch wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inactive volunteers and inactive opportunities no longer show up in the dashboard by default, and are not counted in the results number at the top. Ticking "Inactive" in the filters brings them back.
The reason nothing was filtered before: the query only got a
status(orengagement) param for boxes the user had ticked. On a fresh page load, nothing is ticked, so no param was sent at all, so the server had nothing to filter by and returned everything.The fix supplies a default set when the user has selected nothing, and it does that at the API call site rather than inside the shared serializer.
Both default lists are derived from the SDK enums rather than written by hand, so a new status added later shows up by default instead of silently disappearing.
The counts needed no work.
countcomes back from the server with the filtered list, so filtering the query filters the count.useCopyEmails gets a snapshot of the filter taken before the defaults are applied, so copy-all still includes inactive volunteers
Also open: the issue only mentions inactive, so past opportunities are still visible by default. I was on the fence about including opp-past too and went with what the issue says. Happy to add it, it is one line.
Related Issues
Closes #637
Changes
834888b4) on 24 June, when the SDK had temporarily droppedOpportunityStatusType.INACTIVE. The SDK has the value back, and theopp-inactivetranslation keys were still in both locale files, so this is a one-line revert.DEFAULT_OPPORTUNITY_STATUSESandDEFAULT_VOLUNTEER_ENGAGEMENTS, both derived from the SDK enumsvol-prefix the same way the existing serializer does, since the backend re-adds itScreenshots / Demos
Screencast.from.2026-08-13.06-52-45.mp4
Checklist