fix: main communication language to accept english-alone client-side - #903
fix: main communication language to accept english-alone client-side#903yi171 wants to merge 3 commits into
Conversation
|
Hey @yi171 here is a review : ReviewSmall, well-scoped fix: relaxes the client-side Nit
// The org's main communication language is German, with English as the only
// secondary option — unlike "Residents speak", which allows any language.This describes exactly the old, now-relaxed rule ("German mandatory, English only as an addition"). Worth updating to reflect that German and English are each independently valid, together or alone, so a future reader doesn't get pointed at the wrong invariant. Test coverageNo test exercises the three cases from #894's acceptance criteria (English-alone accepted, German-alone/both still work, a non-German/English pick still rejected) — worth a quick unit test on Nothing blocking — logic is correct and matches the already-relaxed backend. |
Description
fix for english alone to be accepted as the main communication language on client side
redo of closed PR fe#849 to use updated ISO codes instead of titles strings.
Related Issues
Closes #894
Changes
mainCommunicationZod validation inopportunityDetailsSchema.tsto accept German and/or English.mainCommunicationInvaliderror message in both en and de translation files