Fix MSVC container-of-move-only-type workaround in algorithm::traverse#177
Open
a2Fsa2k wants to merge 2 commits into
Open
Fix MSVC container-of-move-only-type workaround in algorithm::traverse#177a2Fsa2k wants to merge 2 commits into
a2Fsa2k wants to merge 2 commits into
Conversation
The bandwidth values in the README refer to gigabytes per second, not gigabits. The correct SI abbreviation for gigabyte is GB (Gb is gigabit). All bandwidth numbers (DDR4, PCIe, NVMe, etc.) are in GB/s. Closes: ned14#159 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The workaround for the MSVC STL defect with vector<list<move-only-type>> was gated on _MSVC_STL_VERSION < 150, but the underlying standard defect affects all MSVC versions. Broaden the check to cover any MSC compiler. Closes: ned14#98
a2Fsa2k
force-pushed
the
fix/msvc-list-workaround
branch
from
c96d106 to
ad1cc46
Compare
Owner
|
The hope had been that Microsoft would fix their STL next revision. But I guess they're not going to. Thanks for the PR. |
Owner
|
I don't think that this fix is the right one, so I won't be merging it as-is. What we really need is for Microsoft's STL to tell us if it needs the workarounds or now. I've requested such a feature macro at microsoft/STL#6302 and we'll see what they say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workaround for the MSVC STL defect where
vector<list<move-only-type>>doesn't compile was gated on_MSVC_STL_VERSION < 150, but the underlying standard defect (see microsoft/STL#1036) affects all current MSVC versions. This broadens the check to cover any MSC compiler.Changes
include/llfio/v2.0/detail/impl/traverse.ipp: Change#if _MSVC_STL_VERSION < 150to#if defined(_MSC_VER)so the moving copy constructor workaround applies to all MSVC versionsCloses: #98