Repository navigation
Conversation
…ermost responder node
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c8a0f4f:
|
1 task done
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2916
getLowestCommonAncestorread the first pair twice, so it never compared the last one. When that was the only common ancestor, it returnednulland no negotiation happened. It now advances the index before reading.Test: Negotiation ›
negotiate from first common ancestor when it has no responder ancestors. It fails without the fix. Its neighbour,negotiate from first common ancestor when there are siblings, passes only because a grandParent is connected to the responder system.A second touch starting on the sibling goes through the same path. The test uses a mouse move, as in the issue.
format,flow,lintandunitpass. The fix also applies as is to0.22-dev.Written with Claude Code; I reviewed the code and the tests.