Repository navigation
Track Clojure test selectors without parent project lookups - #67
Merged
Merged
Conversation
rpalcolea
requested review from
DanielThomas,
OdysseusLives and
chali
as code owners
November 5, 2026 18:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
clojuresque.test.varsnow invalidatesclojureTestinputs so the newly selected tests execute. Resolve the selector once during lazy task configuration, preferring the owning project's extra over tracked Gradle properties. Preserve local-extra precedence over-P, customization timing, explicittestsoverrides, comma splitting, and absent/empty selection behavior. The existingListProperty<String>API is retained and tracked as an optional input.Parent-only extra properties must move to
gradle.properties,-P, or local extra/testsconfiguration in each participating project. The README documents this adoption requirement. This change covers selector ownership and input tracking; enabled uber-JAR configuration-cache issues and documentation-input modeling remain separate work. Whole-plugin Isolated Projects compatibility is not claimed.CI installs Java 8 for the existing toolchain tests and reports full test exceptions. Gradle 8.0 coverage runs on the compatible Java 17 lane; the current wrapper runs across Java 17, 21, and 25. The precedence tests use named configuration options and Spock's combination support.
Validation:
test validatePluginswith Java 17 passed all 90 tests, including 58 selector cases; all 46 selector cases also passed locally on Java 25. GitHub Actions builds pass on Java 17, 21, and 25. The selector tests cover single, sibling, and nested projects under ordinary configuration cache and strict isolation, checking actual selected-test output, selector invalidation, subsequent cache reuse, source edits, and selected failures.