You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CRD reference is missing newer fields and condition reasons, and documents fields that do nothing #41
The field names, types, defaults and validation in the CRD reference match v0.1.1. So do the client ID convention, the secret keys, the namespace label and the nebari.dev/force-reprovision annotation. These are missing or wrong:
spec.landingPage.iconLight / iconDark and the matching status.serviceDiscovery fields, added in v0.1.0 (api/v1/nebariapp_types.go:448-456).
Condition reasons: UserProvidedSecretReady, UserProvidedSecretNotFound, UserProvidedSecretInvalidType, UserProvidedSecretCheckFailed, CertificateCleanupFailed, BuildFailed. The table at docs/site/src/content/docs/nebariapp-crd-reference.md:212-226 also misses reasons that already existed in alpha.19, including RoutingNotConfigured, TLSDisabled, AuthDisabled and ClusterIssuerNotConfigured, which are the ones a reader hits first when a pack doesn't route.
Reasons Available and SecretNotFound are defined but never set.
landingPage.displayName "required when enabled" isn't enforced, and externalUrl defaults to http:// when TLS is off, not always https://.
Fix
Regenerate the field tables from the v0.1.1 CRD, list every reason the controllers set, and mark the unimplemented fields as such, with upstream issues for each.
Verified against this repo at 4e50cd0, nebari-operator v0.1.1 (same commit as operator main), and NIC v0.14.0.
Activity
Match the CRD reference Helm section to #44 so the PRs merge cleanly (#…
Bring the CRD reference up to date with operator v0.1.1 (#41)
Match the CRD reference Helm section to #44 so the PRs merge cleanly (#…