Repository navigation
Description
The basic-nginx and wrap-existing-chart examples, and most NebariApp snippets in the docs, have no spec.routing block. With routing unset, operator v0.1.1 deletes any HTTPRoute, sets RoutingReady=False/RoutingNotConfigured and TLSReady=False/TLSDisabled, creates no Certificate, and still reports Ready=True (internal/controller/nebariapp_controller.go:184-208, internal/controller/reconcilers/tls/reconciler.go:71-74). The pack deploys, goes Ready, and is unreachable through the gateway.
The CRD reference already says this (docs/site/src/content/docs/nebariapp-crd-reference.md:66), so the docs contradict themselves.
Where routing is missing
- Chart values:
examples/basic-nginx/chart/values.yaml:31-46,examples/wrap-existing-chart/chart/values.yaml:9-24.NOTES.txt:6in both charts still prints "HTTPRoute for hostname". - Site:
docs/site/src/content/docs/concepts.md:19-31,docs/site/src/content/docs/concepts.md:84-95,docs/site/src/content/docs/nebariapp-crd-reference.md:258-342(the Helm template there does not passroutingthrough at all), and the mirror indocs/nebariapp-crd-reference.md. - READMEs:
examples/basic-nginx/README.md:17-59,examples/wrap-existing-chart/README.md:39-78,README.md:610-638.
vanilla-yaml, kustomize-nginx and auth-fastapi set routing and work.
Why CI passes
.github/workflows/test-integration.yaml:173-174 waits for Ready and then runs kubectl get httproute, which exits 0 on an empty result. The log for run 36736164169 shows condition met, then No resources found in default namespace., then basic-nginx: NebariApp Ready. wrap-existing-chart does the same.
Fix
- Add
routing.routes: [{pathPrefix: /}]androuting.tls.enabled: trueto both chart values files and every snippet listed above. - Make the integration test assert that the HTTPRoute exists and that
RoutingReadyandTLSReadyareTrue, not onlyReady.
Related: nebari-dev/nebari-docs#738 repeats the same values block without routing.
Verified against this repo at 4e50cd0, nebari-operator v0.1.1 (same commit as operator main), and NIC v0.14.0.
Metadata
Metadata
Assignees
Labels
Type
Fields
Priority
Start date
Target date
Size
Activity
Add routing to examples and docs, and check real traffic in CI (#34)