Skip to content

docs(azure): add the Azure provider page - #779

Open
khuyentran1401 wants to merge 2 commits into
mainfrom
docs/azure-provider-page
Open

khuyentran1401 wants to merge 2 commits into
mainfrom
docs/azure-provider-page

Conversation

@khuyentran1401

Copy link
Copy Markdown
Collaborator

Reference Issues or PRs

Closes #777.

What does this implement/fix?

  • Replaces the "Planned" stub with a full Azure guide that follows the same structure as the AWS and Hetzner pages: prerequisites, cost, configuration, deploy, sign-in, update, upgrade, and destroy.
  • Marks Azure as supported in the provider table.
  • Updates the enterprise TLS proxy note, which said the Azure provider was not built yet.

Testing

  • Did you test the pull request locally?

  • Did you add new tests?

  • Checked fields, defaults, and destroy behavior against the nic source (447ed13) and the aks-cluster module (v0.3.0).

  • Sign-in with az login plus AZURE_SUBSCRIPTION_ID confirmed by a successful nic deploy --dry-run.

  • Not tested with a full deploy, so the load balancer and public IP cost items are still unconfirmed.

@github-actions

Copy link
Copy Markdown

Docs preview for docs/azure-provider-page:

@dcmcand dcmcand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Comment. I checked the page against nic 82753a6 and aks-cluster v0.3.0, and the claims hold, with the corrections inline. None of them block.

💡 Suggestion: The page marks Azure supported but does not list two limitations that a user will hit. Add a short Limitations section.

  • Longhorn is not installed on Azure, so Longhorn backups do not work (provider.go:392-396; backup-restore.md already says this).
  • The enterprise TLS trust_bundle is not installed on Azure nodes, and nic gives no warning.

💡 Suggestion: upgrade-kubernetes.md links the AWS and Hetzner pages for provider-specific upgrade constraints. Add this page there too.


Key: 🛑 Blocker (must fix before merge) · 💡 Suggestion (improvement, not blocking) · ❓ Question (needs author input) · ❤️ Kudos

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document NKP deployment on Azure

2 participants