Repository navigation
chore(images)!: drop the apps- prefix from image names - #169
Merged
Merged
Conversation
The org's pack-build-image workflow already prefixes the repo name, so the matrix's apps-* names produced ghcr.io/nebari-dev/apps-pack/apps-operator and quay.io/nebari/apps-pack-apps-operator. Name the images operator, authz, api, ui and mcp instead, giving ghcr.io/nebari-dev/apps-pack/operator and quay.io/nebari/apps-pack-operator, like the other packs. BREAKING CHANGE: new image tags are published only under the new names. Installs that set *.image.repository must point it at them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ap1Tqx1QLHRGVVSXdxeduM
|
📄 Docs preview for |
This was referenced Oct 22, 2026
jbouder
added a commit
that referenced
this pull request
Oct 22, 2026
Since the gateway took over sign-in and access.groups (nebari-operator v0.2.0 SecurityPolicy, #168), the sidecar authorizes nothing: it proxies requests, records activity for scale to zero and gives image Apps the single front port 8080. The name "authz" made readers think the pod checks access. Rename it before 0.2.0, which already renames the images (#169), and before the Quay repositories are created (#85). The directory, Go module, image, chart values, operator flags, container name, port name and sidecar env vars move from authz to proxy. Ports and behaviour are unchanged. The sidecar still refuses to start when AUTHZ_GROUPS (or another setting of the removed enforcing mode) is set, under its old name on purpose, and now also when it gets its own settings under the old AUTHZ_ names, so an operator from before the rename fails closed instead of starting an App open. AUTHZ_PASSTHROUGH, which nothing read any more, is no longer mentioned. BREAKING CHANGE: the sidecar image is now ghcr.io/nebari-dev/apps-pack/proxy (quay.io/nebari/apps-pack-proxy) and the chart's authz.* values are now proxy.*; the schema rejects the old key. The sidecar container is renamed from authz to proxy, so every pod that runs it rolls once. Upgrade the chart and images together. Claude-Session: https://claude.ai/code/session_01Ap1Tqx1QLHRGVVSXdxeduM Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The org's
pack-build-imageworkflow names imagesghcr.io/nebari-dev/<repo>/<image>andquay.io/nebari/<repo>-<image>. Our matrix names already started withapps-, so the published paths repeated it:apps-pack/apps-operatorandapps-pack-apps-operator.This renames the matrix images to
operator,authz,api,uiandmcp:ghcr.io/nebari-dev/apps-pack/apps-operatorghcr.io/nebari-dev/apps-pack/operatorquay.io/nebari/apps-pack-apps-operatorquay.io/nebari/apps-pack-operatorThe same applies to
authz,api,uiandmcp.images.yaml: the matrix names in both jobs, plus theuisecurity-header checkvalues.yamlrepository defaults and the chart READMEauthz_test.goconstant.upgrading.md: a note for installs that set*.image.repositoryComponent names in prose (apps-api, apps-ui, ...) and the local
dev/image names are unchanged.Breaking
New tags are published only under the new names. Images already pushed stay at the old GHCR paths. No chart has been released yet, so this only affects deployments that track
mainor overrideimage.repository.Related
The Quay repositories to create for #85 become
apps-pack-operator,apps-pack-authz,apps-pack-api,apps-pack-uiandapps-pack-mcp.Checks run locally
bun test🤖 Generated with Claude Code
https://claude.ai/code/session_01Ap1Tqx1QLHRGVVSXdxeduM