Repository navigation
feat(ui): unlock the launch form's landing-page switch - #159
Merged
Merged
Conversation
The switch was read-only because the landing page could hide a tile only by group, not by username. Apps now restrict by group only (#158), so the form offers it again. A launch sends exactly what the switch shows, even when the cluster default is on; an edit sends landingPage only when the switch is flipped, so an App on the cluster default keeps it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016pvMUQJoLkBDk6B94TTm45
|
📄 Docs preview for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlocks Show on the landing page in the launch form's Access section.
It was locked because the landing page can hide a tile only by group (
requiredGroups), so a tile for an App restricted by username would have shown up for everyone. Apps now restrict by group only (#158), so that reason is gone.landingPage.enabledwith whatever the switch shows (off by default). It's sent even when off, so a cluster default of "on" doesn't list an App whose switch showed off.landingPageonly when the switch changes. An App that relies on the cluster default keeps doing so.LANDING_PAGE_LOCKEDflag and the read-only note.launching-apps.mddescribes the switch. The "locked" limitation is removed fromREADME.mdandgetting-started.md.Testing
All of these pass:
npm run check:cinpm run buildnpm test: 252, including new tests that the switch sendsenabled: trueon a launch and that flipping it on an edit sends the change.npm run test:e2e: 143. The launch spec turns the switch on and asserts the request.check_doc_paths.py.🤖 Generated with Claude Code
https://claude.ai/code/session_016pvMUQJoLkBDk6B94TTm45