SVCPLAN-8828: optional env vars, optional exported clients - #15
Merged
jakerundall merged 1 commit intoFeb 17, 2026
Merged
jakerundall merged 1 commit into
jakerundall merged 1 commit into
Conversation
Contributor
Author
|
I've tested this with mg-servicebackup1 (tested w/ and w/o exported clients) and mgdb[1,2] (tested w/ and w/o additional env vars). |
billglick
requested changes
Feb 17, 2026
billglick
left a comment
billglick
left a comment
Member
There was a problem hiding this comment.
A few comments and suggestions.
The main issue is that I would change the exported resource option to be in the client, not exporting it if it isn't set.
jakerundall
force-pushed
the
rundall/SVCPLAN-8828/optionally_set_python_paths_in_defaults_file
branch
from
February 17, 2026 22:26
f43e6f6 to
9cc8257
Compare
Contributor
Author
|
Ready for another look when you get a chance, thanks @billglick ! |
Allow setting additional environment variables in borg_defaults.sh via profile_backup::client::env_vars. Use cases were: - expand PYTHONPATH - override BORG path These help when pip packages need to be installed in alternate locations. Allow override of the network interface that will be used by facter to determine the client's IP. - Jake is not unsure how facter decides the value of networking.ip, but on MG nodes it was the mgmt IP. Now you can tell Puppet/facter to use the IP of another interface, e.g., ib0. Regen REFERENCE.md.
jakerundall
force-pushed
the
rundall/SVCPLAN-8828/optionally_set_python_paths_in_defaults_file
branch
from
February 17, 2026 22:55
9cc8257 to
64b97ff
Compare
jakerundall
deleted the
rundall/SVCPLAN-8828/optionally_set_python_paths_in_defaults_file
branch
February 17, 2026 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting additional environment variables in borg_defaults.sh via profile_backup::client::env_vars. Use cases were:
Allow disabling use of exported clients.