Chore: Drop sparql-client fork pin (de-fork, goo#194) - #311
Merged
Conversation
Part of the sparql-client de-fork (ncbo/goo#194). goo now re-homes all NCBO sparql-client behavior and its gemspec pins sparql-client = 3.2.2 from rubygems, so this repo's fork pin is obsolete and must go: leaving it would keep sourcing the fork, whose baked-in caching would stack with goo's bolt-ons. Lock: goo -> 78ff860 (de-fork merge), sparql-client 3.2.2 (rubygems), fork GIT source removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #311 +/- ##
========================================
Coverage 82.03% 82.03%
========================================
Files 101 101
Lines 6853 6853
========================================
Hits 5622 5622
Misses 1231 1231
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdorf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of the sparql-client de-fork (ncbo/goo#194). goo now depends on vanilla
sparql-client3.2.2 from rubygems and re-homes all NCBO behavior (Redis read-throughcache, union-with-bind DSL, backend quirks) as goo-owned bolt-ons.
This PR drops this repo's own Gemfile pin of the NCBO fork
(
gem 'sparql-client', github: 'ncbo/sparql-client', branch: 'development') and refreshesGemfile.lock:goore-pinned to the currentdevelopmentSHA (includes the de-fork).sparql-clientnow resolves to 3.2.2 from rubygems via goo's gemspec pin (the GIT sourceentry is gone).
Dropping the pin is required, not optional: with the fork pin left in place bundler keeps
sourcing sparql-client from the fork, whose baked-in caching would stack with goo's new
bolt-ons.
No code changes. Runtime behavior is unchanged: caching still keys off
Goo.use_cache(set in this repo's environment configs), and the cache key/format is preserved verbatim,
so existing Redis cache entries stay valid.
Part of the coordinated wave across ontologies_linked_data, ncbo_annotator, ncbo_cron,
ncbo_ontology_recommender, ontologies_api (merged in dependency order).