Skip to content

Chore: Drop sparql-client fork pin (de-fork, goo#194) - #247

Merged
mdorf merged 1 commit into
developfrom
chore/drop-sparql-client-fork-pin
Jul 28, 2026
Merged

Chore: Drop sparql-client fork pin (de-fork, goo#194)#247
mdorf merged 1 commit into
developfrom
chore/drop-sparql-client-fork-pin

Conversation

@mdorf

@mdorf mdorf commented Jul 28, 2026

Copy link
Copy Markdown
Member

Summary

Part of the sparql-client de-fork (ncbo/goo#194). goo now depends on vanilla
sparql-client 3.2.2 from rubygems and re-homes all NCBO behavior (Redis read-through
cache, union-with-bind DSL, backend quirks) as goo-owned bolt-ons.

This PR drops this repo's own Gemfile pin of the NCBO fork
(gem 'sparql-client', github: 'ncbo/sparql-client', branch: 'development') and refreshes
Gemfile.lock:

  • goo re-pinned to the current development SHA (includes the de-fork).
  • sparql-client now resolves to 3.2.2 from rubygems via goo's gemspec pin (the GIT source
    entry is gone).

Dropping the pin is required, not optional: with the fork pin left in place bundler keeps
sourcing sparql-client from the fork, whose baked-in caching would stack with goo's new
bolt-ons.

No code changes. Runtime behavior is unchanged: caching still keys off Goo.use_cache
(set in this repo's environment configs), and the cache key/format is preserved verbatim,
so existing Redis cache entries stay valid.

Part of the coordinated wave across ontologies_linked_data, ncbo_annotator, ncbo_cron,
ncbo_ontology_recommender, ontologies_api (merged in dependency order).

Part of the sparql-client de-fork (ncbo/goo#194). Lock: goo -> 78ff860,
ontologies_linked_data -> 29e9fa7, ncbo_annotator -> c572808,
ncbo_cron -> 4368911, ncbo_ontology_recommender -> b3215d9,
sparql-client 3.2.2 (rubygems), fork GIT source removed.
@codecov-commenter

codecov-commenter commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.76%. Comparing base (92583a1) to head (701091b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #247   +/-   ##
========================================
  Coverage    78.76%   78.76%           
========================================
  Files           68       68           
  Lines         3777     3777           
========================================
  Hits          2975     2975           
  Misses         802      802           
Flag Coverage Δ
ag 78.76% <ø> (ø)
fs 78.76% <ø> (ø)
gd 78.76% <ø> (ø)
unittests 78.76% <ø> (ø)
vo 78.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mdorf
mdorf merged commit 3ba9ed5 into develop Jul 28, 2026
10 checks passed
@mdorf mdorf changed the title Drop sparql-client fork pin (de-fork, goo#194) Chore: Drop sparql-client fork pin (de-fork, goo#194) Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants