Skip to content

Sync nanoFramework.System.Net dependency to 1.11.50 across all projects#486

Closed
CoryCharlton wants to merge 1 commit intonanoframework:mainfrom
CoryCharlton:fix/sync-system-net-dependency-versions
Closed

Sync nanoFramework.System.Net dependency to 1.11.50 across all projects#486
CoryCharlton wants to merge 1 commit intonanoframework:mainfrom
CoryCharlton:fix/sync-system-net-dependency-versions

Conversation

@CoryCharlton
Copy link
Copy Markdown
Member

  • Update packages.config and packages.lock.json to resolve nanoFramework.System.Net 1.11.50
  • Remove stale duplicate System.Net 1.11.47 reference from all three .nfproj files; consolidate into a single reference with Version=1.11.50.0
  • Update nanoFramework.System.Net dependency version in all three .nuspec files from 1.11.47 to 1.11.50

Description

  • Sync nanoFramework.System.Net dependency to 1.11.50 across all projects

Motivation and Context

How Has This Been Tested?

It builds ;-)

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Update packages.config and packages.lock.json to resolve nanoFramework.System.Net 1.11.50
- Remove stale duplicate System.Net 1.11.47 reference from all three .nfproj files; consolidate into a single reference with Version=1.11.50.0
- Update nanoFramework.System.Net dependency version in all three .nuspec files from 1.11.47 to 1.11.50
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 11150153-bde4-4d9f-a424-28eafdbf5081

📥 Commits

Reviewing files that changed from the base of the PR and between 9500f0c and d575bb7.

📒 Files selected for processing (12)
  • nanoFramework.System.Net.Http.Client.nuspec
  • nanoFramework.System.Net.Http.Client/System.Net.Http.Client.nfproj
  • nanoFramework.System.Net.Http.Client/packages.config
  • nanoFramework.System.Net.Http.Client/packages.lock.json
  • nanoFramework.System.Net.Http.Server.nuspec
  • nanoFramework.System.Net.Http.Server/System.Net.Http.Server.nfproj
  • nanoFramework.System.Net.Http.Server/packages.config
  • nanoFramework.System.Net.Http.Server/packages.lock.json
  • nanoFramework.System.Net.Http.nuspec
  • nanoFramework.System.Net.Http/System.Net.Http.nfproj
  • nanoFramework.System.Net.Http/packages.config
  • nanoFramework.System.Net.Http/packages.lock.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the system network library dependency to version 1.11.50 across HTTP client and server packages.

Walkthrough

This pull request updates the nanoFramework.System.Net dependency from version 1.11.47 to 1.11.50 across three HTTP-related packages (Client, Server, and Http) and their associated NuGet configuration and project files.

Changes

Cohort / File(s) Summary
Http.Client Package
nanoFramework.System.Net.Http.Client.nuspec, nanoFramework.System.Net.Http.Client/System.Net.Http.Client.nfproj, nanoFramework.System.Net.Http.Client/packages.config, nanoFramework.System.Net.Http.Client/packages.lock.json
Updated nanoFramework.System.Net dependency from version 1.11.47 to 1.11.50 in nuspec, project reference, package configuration, and lock file.
Http.Server Package
nanoFramework.System.Net.Http.Server.nuspec, nanoFramework.System.Net.Http.Server/System.Net.Http.Server.nfproj, nanoFramework.System.Net.Http.Server/packages.config, nanoFramework.System.Net.Http.Server/packages.lock.json
Updated nanoFramework.System.Net dependency from version 1.11.47 to 1.11.50 in nuspec, project reference, package configuration, and lock file.
Http Package
nanoFramework.System.Net.Http.nuspec, nanoFramework.System.Net.Http/System.Net.Http.nfproj, nanoFramework.System.Net.Http/packages.config, nanoFramework.System.Net.Http/packages.lock.json
Updated nanoFramework.System.Net dependency from version 1.11.47 to 1.11.50 in nuspec, project reference, package configuration, and lock file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

Area: Config-and-Build

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the nanoFramework.System.Net dependency across all projects to version 1.11.50, which matches the changeset.
Description check ✅ Passed The description is directly related to the changeset, detailing the specific files modified (packages.config, packages.lock.json, .nfproj files, .nuspec files) and the dependency version changes from 1.11.47 to 1.11.50.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CoryCharlton
Copy link
Copy Markdown
Member Author

@coderabbitai are you able to approve running those two pending checks?

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@CoryCharlton Thanks for checking. I don’t have the repository permissions to approve pending GitHub Actions runs, so I can’t approve those two checks directly.

What I can do:

  • I’ve listed the current check/workflow status above. If you need, I can tag a maintainer to click Approve and run.
  • For a maintainer: open the PR’s Checks tab and click “Approve and run all workflows,” or go to Actions → the run marked “Requires approval” → Approve and run.
  • CLI option for a maintainer with write access:
    • Find the run ID from the list above, then run:
      gh api --method POST "repos/nanoframework/System.Net.Http/actions/runs/<RUN_ID>/approve"

Would you like me to ping a specific maintainer to approve these?


🏁 Script executed:

#!/bin/bash
set -euo pipefail

PR_NUMBER=486

echo "Detecting repository..."
REPO_JSON=$(gh repo view --json nameWithOwner)
REPO=$(echo "$REPO_JSON" | jq -r '.nameWithOwner')
echo "Repository: $REPO"

echo
echo "== PR checks summary =="
# This prints human-readable status of checks; may show 'Waiting'/'Pending approval'
gh pr checks "$PR_NUMBER" || true

echo
echo "== PR head details =="
PR_JSON=$(gh api "repos/$REPO/pulls/$PR_NUMBER")
HEAD_SHA=$(echo "$PR_JSON" | jq -r '.head.sha')
HEAD_REF=$(echo "$PR_JSON" | jq -r '.head.ref')
FROM_FORK=$(echo "$PR_JSON" | jq -r '(.head.repo.full_name != .base.repo.full_name)')
echo "Head ref: $HEAD_REF"
echo "Head sha: $HEAD_SHA"
echo "From fork: $FROM_FORK"

echo
echo "== Check runs for head commit =="
# Lists Checks API runs (may include Actions and other providers)
gh api "repos/$REPO/commits/$HEAD_SHA/check-runs" | jq -r '.check_runs[] | "\(.name): status=\(.status), conclusion=\(.conclusion)"' || true

echo
echo "== Workflow runs requiring approval (status=waiting) =="
# Lists Actions workflow runs that are waiting (often due to required approval)
gh api "repos/$REPO/actions/runs?event=pull_request&status=waiting" | jq -r '.workflow_runs[] | "\(.id)\t\(.name)\thead_branch=\(.head_branch)\tstatus=\(.status)"' || true

Length of output: 919


@CoryCharlton All set—there are no pending approvals now. Current status for PR #486 at commit d575bb7:

  • nanoFramework / NuGets using latest version — passed
  • nanoFramework / package.lock exists — passed
  • license/cla — passed
  • CodeRabbit — passed
  • No workflow runs in waiting status

If you push new commits from the fork and GitHub pauses runs again, a maintainer can:

  • Checks tab → Approve and run all workflows, or
  • CLI: gh api --method POST "repos/nanoframework/System.Net.Http/actions/runs/<RUN_ID>/approve"

Want me to ping someone if it blocks again?

@CoryCharlton CoryCharlton deleted the fix/sync-system-net-dependency-versions branch April 8, 2026 15:12
@nfbot nfbot added invalid This doesn't seem right and removed Area: Config-and-Build labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants