feat(solid): @SolidQuery previousReady / previousError (annotations dev.4 + generator dev.8) - #114
Merged
Merged
Conversation
Extend the retained-state query feature to previousReady/previousError, backing solidart 3.0.0-dev.2's new Resource.previousReady/previousError. solid_annotations 3.0.0-dev.4: previousReady/previousError source-time stubs on the query tear-off — the most recent ready/error state, retained across ANY number of failures (unlike previousState, the single prior state). Read as <query>.previousReady?.value / <query>.previousError?.error. solid_generator 3.0.0-dev.8: recognize <query>.previousReady/.previousError (same-class + cross-instance, origin-qualified) as tracked reads, so a build() reading only a retained-state getter gets the SignalBuilder wrap + import. Generalizes the previousState recognition to the getter set; refresh stays untracked. New goldens prove same-class previousReady and cross-instance previousReady/previousError standalone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the @SolidQuery retained-state feature from previousState to also cover previousReady and previousError, backing solidart 3.0.0-dev.2's Resource.previousReady/previousError (most recent ready/error state, retained across any number of failures).
364 tests pass, analyze + format clean; 2 adversarial reviewers, no defects.