backend/fix: implement withForkCounters in the cluster pipeline test monad - #1517
Conversation
…monad 0a8170e added withForkCounters to CoreMetrics without a default. #1516 was based on the commit before it and added a CoreMetrics instance for the Redis cluster test monad (TestM) that does not define it, so after both merged, mobility-core-tests fails with -Wmissing-methods under -Werror. TestM's metrics are no-ops, so withForkCounters just runs the action.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe ChangesTest Metrics Support
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This test-only change completes the metrics stub without changing runtime behavior. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit counts no forks today Comment |
What
Adds
withForkCounters _ _ action = actionto theCoreMetricsinstance ofTestMintest/src/HedisClusterPipeline.hs.Why
0a8170e9addedwithForkCountersto theCoreMetricsclass without a default. #1516 was based on the commit before it and added aCoreMetricsinstance for the Redis cluster test monad that doesn't define it. Both merged cleanly on their own, but togethermobility-core-testsfails with-Wmissing-methodsunder-Werror. Only the test suite is affected; the library is unchanged.TestM's metrics are all no-ops, sowithForkCountersjust runs the action. No otherCoreMetricsinstance in the repo is missing the method.Summary by CodeRabbit