Skip to content

fix: stripeLegalEntityName - #1512

Merged
khuzema786 merged 1 commit into
mainfrom
feat/stripe-legal-entity-name
Sep 10, 2026
Merged

khuzema786 merged 1 commit into
mainfrom
feat/stripe-legal-entity-name

Conversation

@TejaswiniT167

@TejaswiniT167 TejaswiniT167 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Summary by CodeRabbit

  • New Features
    • Stripe payment configurations can now include an optional legal entity name.
    • The configured legal entity name can be retrieved when available.
    • Legal entity names remain unavailable for Juspay and Paytm EDC payment configurations.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5feae843-a34b-4775-a76a-2752b1e0d04e

📥 Commits

Reviewing files that changed from the base of the PR and between 7cbc84a and 061dfec.

📒 Files selected for processing (2)
  • lib/mobility-core/src/Kernel/External/Payment/Interface.hs
  • lib/mobility-core/src/Kernel/External/Payment/Stripe/Config.hs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The change adds an optional legal entity name to Stripe configuration and exposes a helper that returns it for Stripe while returning Nothing for Juspay and Paytm EDC.

Changes

Payment legal entity

Layer / File(s) Summary
Legal entity configuration and accessor
lib/mobility-core/src/Kernel/External/Payment/Stripe/Config.hs, lib/mobility-core/src/Kernel/External/Payment/Interface.hs
StripeCfg now includes an optional legalEntityName field. The legalEntityName helper returns the Stripe value and returns Nothing for Juspay and Paytm EDC configurations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: khuzema786, hari-krishna-dupaguntla

Merge Risk: ⚪ Minimal · up to 061df

This adds an optional Stripe legal entity name and exposes it through the payment configuration interface. No concrete merge-blocking correctness or availability risk is evident from the supplied change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the Stripe legal entity name fix. It is concise and directly related to the added legalEntityName field and helper function.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/stripe-legal-entity-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@khuzema786
khuzema786 merged commit 4c6c4b2 into main Sep 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants