Repository navigation
refactor: cleanups for error refactor - #137
Merged
Merged
Conversation
`send` resets the stream if a message is too large or does not encode, but `try_send` only returned the error. The sender then closed, and the drop of the stream finished it, so the receiver saw a clean end instead of an error. Both now encode through one helper that resets the stream.
`mem::take` with a `Default` impl hid the state that a cancelled send leaves behind. `take_for_send` names it and says why the sender stays closed.
Inline links with a target that differs from their text make the doc comments harder to read in the source. They now point to reference definitions at the end of each doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minor tweaks to the error refactor (#130):
NoqSendState