Repository navigation
Conversation
rklaehn
marked this pull request as ready for review
October 9, 2026 07:11
rklaehn
commented
Oct 9, 2026
| "failed to read size", | ||
| ))?; | ||
| // A sender that is dropped without sending finishes the stream. | ||
| let Some(size) = read.read_varint_u64().await? else { |
Collaborator
Author
There was a problem hiding this comment.
read_varint_u64 returns None exactly when the stream closes cleanly at 0 bytes. All other errors, e.g. 1 byte then close, will not produce SenderClosed!
Member
|
This was merged into #130. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #134.
A remote
oneshot::Senderthat is dropped without sending finishes the stream at 0 bytes. The receiver currently getsRecvError::Io("failed to read size") for that, while locally it getsSenderClosed. This maps the empty stream toSenderClosed.A stream that ends inside a message is still an io error.