Repository navigation
UIをgocuiからBubble Teaへ移行 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| # Plan: 検索マッチのハイライト表示 | ||
| # Plan: UI を gocui から Bubble Tea へ移行 | ||
|
|
||
| ## タスク | ||
| - [x] 1. `highlightMatch(name, query string) string` ヘルパー関数を追加 | ||
| - [x] 2. `renderEntries`で検索クエリがある場合にハイライト適用 | ||
| - [x] 3. テスト作成(`highlightMatch`のユニットテスト) | ||
| - [x] 4. ビルド・テスト・フォーマット確認 | ||
| - [x] 1. ブランチ作成(feat/migrate-bubbletea) | ||
| - [x] 2. go get(bubbletea / lipgloss / bubbles) | ||
| - [x] 3. gomarkdoc で docs/lib/{bubbletea,lipgloss,textinput}.md 生成 | ||
| - [x] 4. App を tea.Model 化(Init/Update/View)— 通常モードのペイン描画・移動 | ||
| - [x] 5. 入力モード(textinput)・確認モード・検索/フィルタ・作成/リネーム移植 | ||
| - [x] 6. セレクタポップアップ移植(中央モーダル) | ||
| - [x] 7. gocui 依存コード削除(SetGui/Layout/render*/keybinding登録/inputEditor/selector View群) | ||
| - [x] 8. main.go 置換、flake.nix vendorHash 更新、docs/lib/gocui.md 削除、design.md/CLAUDE.md 更新 | ||
| - [x] 9. gofmt → golangci-lint → go test ./... → nix build | ||
| - [ ] 10. PR 作成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
テーブルセル内のコードスパンに
|が含まれて列数を誤認識させている。|ghq list | fzfの実行...の|がテーブル区切りと解釈される。Markdown パーサーによっては列ずれが発生する。📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 91-91: Spaces inside code span elements
(MD038, no-space-in-code)
[warning] 91-91: Table column count
Expected: 2; Actual: 3; Too many cells, extra data will be missing
(MD056, table-column-count)
🤖 Prompt for AI Agents