Conversation
The documented CSS variable was a typo. Media Chrome / Mux Player exposes --media-object-fit (maps to object-fit). mux.com fetches this REFERENCE.md as the player API source of truth, so the live docs still showed the wrong name. Co-authored-by: Dave Kiss <davekiss@users.noreply.github.com>
davekiss
marked this pull request as ready for review
September 10, 2026 10:48
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs feedback
Also (duplicate submission):
Summary
Docs feedback: the Mux Player CSS variables section documented
--media-object-size, but the correct Media Chrome / Mux Player variable is--media-object-fit(maps toobject-fit).mux.com fetches
packages/mux-player/REFERENCE.mdas the player API source of truth, so the live player API reference still showed the wrong name. A prior mux.com PR (#2334) only added a render-time rewrite; this fixes it at the source instead.Change
packages/mux-player/REFERENCE.mdunder CSS variables / “Other CSS variables”, replace--media-object-size: cover;with--media-object-fit: cover;.--media-object-positionunchanged.This matches the variable already used in package code (e.g.
mux-player-react).QA
packages/mux-player/REFERENCE.mdstill has--media-object-size: cover;; PR branch replaces with--media-object-fit: cover;and keeps--media-object-position. Identifier matches Media Chromeobject-fitnaming (notsize). Single-line docs typo fix.Test plan
REFERENCE.mduses--media-object-fitand still documents--media-object-position.--media-object-sizeoccurrences remain inpackages/mux-playerdocs.