Skip to content

fix(ci): let the claude review post its inline comments - #51

Merged
musingfox merged 1 commit into
mainfrom
ci/fix-claude-review
Oct 10, 2026
Merged

musingfox merged 1 commit into
mainfrom
ci/fix-claude-review

Conversation

@musingfox

@musingfox musingfox commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

The Claude Code Review run reviews the PR but cannot post what it finds.

On the canary PR #49 (run 38066240558, full output from #50) the review found the planted bug, then:

  • mcp_servers was [], so the plugin's mcp__github_inline_comment__create_inline_comment tool did not exist.
  • Claude fell back to gh api .../pulls/49/comments, which is not in the plugin's allowed tools, and was denied (permission_denials_count: 1).

claude-code-action only starts that MCP server when claude_args --allowedTools names it (src/mcp/install-mcp-server.ts, hasInlineCommentTools). This passes the plugin's own allowed-tools list through claude_args, as the action's examples/pr-review-comprehensive.yml does, and turns show_full_output back off.

This PR's own review run will be skipped: the action refuses a PR whose workflow differs from main. Verification happens on #49 after merge.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the automated code review workflow to support inline review comments and a limited set of issue and pull request actions. This change affects the review process and does not alter the app’s user-facing features.

claude-code-action starts the github_inline_comment MCP server only when
claude_args --allowedTools names it. With no claude_args the code-review
plugin's comment tool was missing, Claude fell back to gh api, and that call
was denied, so a found bug never reached the PR (run 38066240558). Also turns
show_full_output back off.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 464bcaa7-dedd-4981-aa8a-3e74871afa80

📥 Commits

Reviewing files that changed from the base of the PR and between 51623b8 and aa78efc.


📒 Files selected for processing (1)
  • .github/workflows/claude-code-review.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.



📝 Walkthrough

Walkthrough

The Claude code review workflow replaces show_full_output: true with Claude CLI arguments that allow the inline-comment creation MCP tool and specified gh issue and pull-request commands.

Changes

Claude review workflow

Layer / File(s) Summary
Configure review arguments
.github/workflows/claude-code-review.yml
The workflow removes show_full_output: true and adds Claude CLI arguments for the inline-comment creation MCP tool and specified gh issue and pull-request commands.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to aa78e

The workflow configuration appears to permit the inline-comment tool, with no established issue requiring resolution before merge.

Architecture Summary

Architecture risk: 🔵 Low · up to aa78e

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/claude-code-review.yml: The workflow removes show_full_output: true and adds Claude CLI arguments that allow the inline-comment creation tool and listed gh issue and pull-request commands.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: enabling the Claude review workflow to post inline comments.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@musingfox
musingfox merged commit 24fc314 into main Oct 10, 2026
4 checks passed
@musingfox
musingfox deleted the ci/fix-claude-review branch October 10, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant