Skip to content

test(facebook): halve the nested message depth to keep a margin on ci - #9

Merged
musingfox merged 1 commit into
mainfrom
test/nested-message-margin
Oct 1, 2026
Merged

musingfox merged 1 commit into
mainfrom
test/nested-message-margin

Conversation

@musingfox

@musingfox musingfox commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

a deeply nested message stays within the cpu budget timed 8.2–10.3 ms over the last seven GitHub runner runs, against a 10 ms limit. The 10.25 ms run failed CI on #7. Halving the depth to 15000 keeps the absolute 10 ms budget and still pins linear handling of deep nesting. Locally the median drops from about 5.7 ms to 2.5 ms.

Test plan

  • bun run check passes locally.
  • CI passes with the new median well under 10 ms.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • 測試
    • 將深層巢狀訊息的 CPU 預算測試層數由 30,000 調整為 15,000;其他測試邏輯與預期結果不變。

At 30000 levels the parse took 8.2-10.3 ms on GitHub runners against a 10 ms
budget, and one run went over. 15000 levels still pins linear handling of deep
nesting and leaves the runner about twice the headroom.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
CLAUDE.md — configured

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: musingfox/better-link/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 63ae0736-a54a-477c-959e-d2dedebf0034

📥 Commits

Reviewing files that changed from the base of the PR and between 51499c9 and b185544.

📒 Files selected for processing (1)
  • test/facebook.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

深層巢狀訊息效能測試將巢狀 <div> 標籤數量從各 30,000 改為各 15,000。解析結果與中位時間檢查維持不變。

Changes

深層巢狀訊息測試

Layer / File(s) Summary
調整巢狀輸入數量
test/facebook.test.ts
測試產生的巢狀 <div> 開始與結束標籤數量改為各 15,000。測試仍驗證解析結果為 "x",並檢查五次解析的中位時間低於 10 毫秒。

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b1855

This change reduces the depth of a parser stress test while retaining its caption and timing checks. No concrete product-impacting risk is evident; normal CI validation remains appropriate before merge.

Architecture Summary

Architecture risk: 🔵 Low · up to b1855

The change affects 1 system.

Changed systems: test

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — test (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in test/facebook.test.ts: 深層巢狀訊息效能測試將產生的巢狀 <div> 開始與結束標籤數量,從各 30,000 改為各 15,000;測試仍驗證解析結果為 "x",並檢查五次解析的中位時間低於 10 毫秒。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 標題清楚說明將巢狀訊息深度減半,以保留 CI CPU 預算裕度,且符合變更內容。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@musingfox
musingfox merged commit 94907db into main Oct 1, 2026
2 checks passed
@musingfox
musingfox deleted the test/nested-message-margin branch October 1, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant