Repository navigation
test(facebook): halve the nested message depth to keep a margin on ci - #9
Conversation
At 30000 levels the parse took 8.2-10.3 ms on GitHub runners against a 10 ms budget, and one run went over. 15000 levels still pins linear handling of deep nesting and leaves the runner about twice the headroom. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: musingfox/better-link/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthrough深層巢狀訊息效能測試將巢狀 Changes深層巢狀訊息測試
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change reduces the depth of a parser stress test while retaining its caption and timing checks. No concrete product-impacting risk is evident; normal CI validation remains appropriate before merge. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
a deeply nested message stays within the cpu budgettimed 8.2–10.3 ms over the last seven GitHub runner runs, against a 10 ms limit. The 10.25 ms run failed CI on #7. Halving the depth to 15000 keeps the absolute 10 ms budget and still pins linear handling of deep nesting. Locally the median drops from about 5.7 ms to 2.5 ms.Test plan
bun run checkpasses locally.🤖 Generated with Claude Code
Summary by CodeRabbit