test(web): assert the app-icon sync in the AppRoot tree - #21
Merged
Conversation
`AppRoot` gained an `<AppIconSync />` beside the voice provider when the app icon chooser landed, but the structural test still expected a single child of the atom registry. Model: Claude Opus 5, harness: Claude Code
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/AppRoot.test.tsxasserts the exact renderer-wide provider tree. The app icon chooser added<AppIconSync />as a second child ofAppAtomRegistryProvider(it needs the registry because the choice is a server setting), so the test failed with expected [ … ] to have a length of 1 but got 2.Fix
The test now expects both children and follows the voice provider at index 1, with a note on why the icon sync sits there.
Verification
vp test run src/AppRoot.test.tsx— passing. Web typecheck clean.Model: Claude Opus 5, harness: Claude Code